Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.md #270

Closed
wants to merge 3 commits into from
Closed

Update build.md #270

wants to merge 3 commits into from

Conversation

shangjianan2
Copy link
Contributor

@shangjianan2 shangjianan2 commented Oct 26, 2023

gradle构建之后文件名现为application-2.10.1-SNAPSHOT.jar

None

gradle构建之后文件名现为application-2.10.1-SNAPSHOT.jar
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:33am

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ruibaby after the PR has been reviewed.
You can assign the PR to them by writing /assign @ruibaby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 26, 2023
ruibaby and others added 2 commits October 26, 2023 17:23
Co-authored-by: John Niang <johnniang@foxmail.com>
Co-authored-by: John Niang <johnniang@foxmail.com>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要同步修改 docs/developer-guide/core/build.md

@JohnNiang
Copy link
Member

JohnNiang commented Oct 27, 2023

Hi @shangjianan2 ,这里可以不用关闭当前 PR,直接往分支 shangjianan2:patch-1 添加新的 commit 即可。

参考:

@shangjianan2
Copy link
Contributor Author

Hi @shangjianan2 ,这里可以不用关闭当前 PR,直接往分支 shangjianan2:patch-1 添加新的 commit 即可。

参考:

多谢指导。

我提交了一个新的pr,审批流程好像卡住了。是我提交的不规范吗?需要加什么标签吗(上面提示"Not mergeable. Needs approved, lgtm labels")?

@JohnNiang
Copy link
Member

Hi @shangjianan2 ,这里可以不用关闭当前 PR,直接往分支 shangjianan2:patch-1 添加新的 commit 即可。
参考:

多谢指导。

我提交了一个新的pr,审批流程好像卡住了。是我提交的不规范吗?需要加什么标签吗(上面提示"Not mergeable. Needs approved, lgtm labels")?

因为你是 First-time contributor,所以需要我们手动点击运行才行。具体可参考:https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants