Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentations #272

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

shangjianan2
Copy link
Contributor

优化halo文档(开发者指南->系统开发->构建)

/kind documentation

None

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 8:40am

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 27, 2023
@shangjianan2 shangjianan2 changed the title docs: improve documentations (#4771) docs: improve documentations Oct 27, 2023
@shangjianan2
Copy link
Contributor Author

@guqing 请问pr需要什么特殊流程吗?目前提示“Not mergeable. Needs approved, lgtm labels.”,是需要加什么标签吗?

image

@shangjianan2 shangjianan2 mentioned this pull request Oct 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Oct 27, 2023

这个 PR 也没有修改 docs 目录的,#270 (review)

在这个分支上修改之后继续推送 commit 即可,不需要再提交 PR。

Signed-off-by: “shangjianan2” <1978707987@qq.com>
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for your first contribution!

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2a38801 into halo-dev:main Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants