An issue with encoding

[przemekd]

I don't know if it is by design or not, but when not specifying all tags I get a badly encoded byte array. For example:

package main

import (
	"encoding/hex"
	"fmt"
	"log"
	"github.com/hamba/avro"
)

type SimpleRecord struct {
	A string  `avro:"a"`
	C *string `avro:"c"`
}

func main() {
	schema, _ := avro.Parse(`{
    "type": "record",
    "name": "simple",
    "namespace": "org.hamba.avro",
    "fields" : [
        {"name": "a", "type": "string"},
        {"name": "b", "type": ["null", "string"], "default": null},
        {"name": "c", "type": ["null", "string"], "default": null}
    ]}`)

	in := SimpleRecord{A: "test", C: nil}
	data, _ := avro.Marshal(schema, in)
	fmt.Println(hex.Dump(data))
}

The output is:
00000000 08 74 65 73 74 00 |.test.| (it misses 00 and it's not correctly binary serialized avro object)

I would expect having default values encoded, even if they are not specified in a struct.

[nrwiersma]

Yeah, that is wrong. Will add a test for this case and see what is going on.

Thanks for reporting.

[nrwiersma]

This should be fixed in v0.5.3. Please let me know if this fixes things for you?

Thanks again.

[przemekd]

Yay, it works! Thanks for fixing it so quick!

[nrwiersma]

No worries. Thanks again for reporting.