Skip to content

Commit

Permalink
Java 7 Clean Up
Browse files Browse the repository at this point in the history
Explicit type argument T can be replaced with <>
  • Loading branch information
nhojpatrick committed Feb 13, 2022
1 parent 0ba3f59 commit 3929ae3
Show file tree
Hide file tree
Showing 27 changed files with 55 additions and 55 deletions.
4 changes: 2 additions & 2 deletions hamcrest/src/main/java/org/hamcrest/Condition.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
public abstract class Condition<T> {

public static final NotMatched<Object> NOT_MATCHED = new NotMatched<Object>();
public static final NotMatched<Object> NOT_MATCHED = new NotMatched<>();

public interface Step<I, O> {
Condition<O> apply(I value, Description mismatch);
Expand All @@ -31,7 +31,7 @@ public static <T> Condition<T> notMatched() {
}

public static <T> Condition<T> matched(final T theValue, final Description mismatch) {
return new Matched<T>(theValue, mismatch);
return new Matched<>(theValue, mismatch);
}

private static final class Matched<T> extends Condition<T> {
Expand Down
2 changes: 1 addition & 1 deletion hamcrest/src/main/java/org/hamcrest/beans/HasProperty.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <T> Matcher<T> hasProperty(String propertyName) {
return new HasProperty<T>(propertyName);
return new HasProperty<>(propertyName);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ protected String descriptionEnd() {
* @return The matcher.
*/
public static <T> IsArray<T> array(Matcher<? super T>... elementMatchers) {
return new IsArray<T>(elementMatchers);
return new IsArray<>(elementMatchers);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class IsArrayContainingInAnyOrder<E> extends TypeSafeMatcher<E[]> {
private final Collection<Matcher<? super E>> matchers;

public IsArrayContainingInAnyOrder(Collection<Matcher<? super E>> matchers) {
this.iterableMatcher = new IsIterableContainingInAnyOrder<E>(matchers);
this.iterableMatcher = new IsIterableContainingInAnyOrder<>(matchers);
this.matchers = matchers;
}

Expand Down Expand Up @@ -86,7 +86,7 @@ public static <E> Matcher<E[]> arrayContainingInAnyOrder(Matcher<? super E>... i
* @return The matcher.
*/
public static <E> Matcher<E[]> arrayContainingInAnyOrder(Collection<Matcher<? super E>> itemMatchers) {
return new IsArrayContainingInAnyOrder<E>(itemMatchers);
return new IsArrayContainingInAnyOrder<>(itemMatchers);
}

/**
Expand All @@ -110,11 +110,11 @@ public static <E> Matcher<E[]> arrayContainingInAnyOrder(Collection<Matcher<? su
* @return The matcher.
*/
public static <E> Matcher<E[]> arrayContainingInAnyOrder(E... items) {
List<Matcher<? super E>> matchers = new ArrayList<Matcher<? super E>>();
List<Matcher<? super E>> matchers = new ArrayList<>();
for (E item : items) {
matchers.add(equalTo(item));
}
return new IsArrayContainingInAnyOrder<E>(matchers);
return new IsArrayContainingInAnyOrder<>(matchers);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class IsArrayContainingInOrder<E> extends TypeSafeMatcher<E[]> {
private final IsIterableContainingInOrder<E> iterableMatcher;

public IsArrayContainingInOrder(List<Matcher<? super E>> matchers) {
this.iterableMatcher = new IsIterableContainingInOrder<E>(matchers);
this.iterableMatcher = new IsIterableContainingInOrder<>(matchers);
this.matchers = matchers;
}

Expand Down Expand Up @@ -55,7 +55,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <E> Matcher<E[]> arrayContaining(E... items) {
List<Matcher<? super E>> matchers = new ArrayList<Matcher<? super E>>();
List<Matcher<? super E>> matchers = new ArrayList<>();
for (E item : items) {
matchers.add(equalTo(item));
}
Expand Down Expand Up @@ -97,7 +97,7 @@ public static <E> Matcher<E[]> arrayContaining(Matcher<? super E>... itemMatcher
* @return The matcher.
*/
public static <E> Matcher<E[]> arrayContaining(List<Matcher<? super E>> itemMatchers) {
return new IsArrayContainingInOrder<E>(itemMatchers);
return new IsArrayContainingInOrder<>(itemMatchers);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ protected Integer featureValueOf(Collection<? extends E> actual) {
* @return The matcher.
*/
public static <E> Matcher<Collection<? extends E>> hasSize(Matcher<? super Integer> sizeMatcher) {
return new IsCollectionWithSize<E>(sizeMatcher);
return new IsCollectionWithSize<>(sizeMatcher);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <E> Matcher<Collection<? extends E>> empty() {
return new IsEmptyCollection<E>();
return new IsEmptyCollection<>();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <E> Matcher<Iterable<? extends E>> emptyIterable() {
return new IsEmptyIterable<E>();
return new IsEmptyIterable<>();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected Integer featureValueOf(Iterable<E> actual) {
* @return The matcher.
*/
public static <E> Matcher<Iterable<E>> iterableWithSize(Matcher<? super Integer> sizeMatcher) {
return new IsIterableWithSize<E>(sizeMatcher);
return new IsIterableWithSize<>(sizeMatcher);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public final class ComparatorMatcherBuilder<T> {
* @return The matcher.
*/
public static <T extends Comparable<T>> ComparatorMatcherBuilder<T> usingNaturalOrdering() {
return new ComparatorMatcherBuilder<T>(new Comparator<T>() {
return new ComparatorMatcherBuilder<>(new Comparator<T>() {
@Override
public int compare(T o1, T o2) {
return o1.compareTo(o2);
Expand All @@ -47,7 +47,7 @@ public int compare(T o1, T o2) {
* @return The matcher.
*/
public static <T> ComparatorMatcherBuilder<T> comparedBy(Comparator<T> comparator) {
return new ComparatorMatcherBuilder<T>(comparator, true);
return new ComparatorMatcherBuilder<>(comparator, true);
}

private ComparatorMatcherBuilder(Comparator<T> comparator, boolean includeComparatorInDescription) {
Expand Down Expand Up @@ -128,7 +128,7 @@ private static String asText(int comparison) {
* @return The matcher.
*/
public Matcher<T> comparesEqualTo(T value) {
return new ComparatorMatcher<T>(comparator, value, ComparatorMatcher.EQUAL, ComparatorMatcher.EQUAL, includeComparatorInDescription);
return new ComparatorMatcher<>(comparator, value, ComparatorMatcher.EQUAL, ComparatorMatcher.EQUAL, includeComparatorInDescription);
}

/**
Expand All @@ -143,7 +143,7 @@ public Matcher<T> comparesEqualTo(T value) {
* @return The matcher.
*/
public Matcher<T> greaterThan(T value) {
return new ComparatorMatcher<T>(comparator, value, ComparatorMatcher.GREATER_THAN, ComparatorMatcher.GREATER_THAN, includeComparatorInDescription);
return new ComparatorMatcher<>(comparator, value, ComparatorMatcher.GREATER_THAN, ComparatorMatcher.GREATER_THAN, includeComparatorInDescription);
}

/**
Expand All @@ -158,7 +158,7 @@ public Matcher<T> greaterThan(T value) {
* @return The matcher.
*/
public Matcher<T> greaterThanOrEqualTo(T value) {
return new ComparatorMatcher<T>(comparator, value, ComparatorMatcher.EQUAL, ComparatorMatcher.GREATER_THAN, includeComparatorInDescription);
return new ComparatorMatcher<>(comparator, value, ComparatorMatcher.EQUAL, ComparatorMatcher.GREATER_THAN, includeComparatorInDescription);
}

/**
Expand All @@ -173,7 +173,7 @@ public Matcher<T> greaterThanOrEqualTo(T value) {
* @return The matcher.
*/
public Matcher<T> lessThan(T value) {
return new ComparatorMatcher<T>(comparator, value, ComparatorMatcher.LESS_THAN, ComparatorMatcher.LESS_THAN, includeComparatorInDescription);
return new ComparatorMatcher<>(comparator, value, ComparatorMatcher.LESS_THAN, ComparatorMatcher.LESS_THAN, includeComparatorInDescription);
}

/**
Expand All @@ -188,7 +188,7 @@ public Matcher<T> lessThan(T value) {
* @return The matcher.
*/
public Matcher<T> lessThanOrEqualTo(T value) {
return new ComparatorMatcher<T>(comparator, value, ComparatorMatcher.LESS_THAN, ComparatorMatcher.EQUAL, includeComparatorInDescription);
return new ComparatorMatcher<>(comparator, value, ComparatorMatcher.LESS_THAN, ComparatorMatcher.EQUAL, includeComparatorInDescription);
}

}
2 changes: 1 addition & 1 deletion hamcrest/src/main/java/org/hamcrest/core/DescribedAs.java
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public void describeMismatch(Object item, Description description) {
* @return The matcher.
*/
public static <T> Matcher<T> describedAs(String description, Matcher<T> matcher, Object... values) {
return new DescribedAs<T>(description, matcher, values);
return new DescribedAs<>(description, matcher, values);
}

}
2 changes: 1 addition & 1 deletion hamcrest/src/main/java/org/hamcrest/core/IsNot.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <T> Matcher<T> not(Matcher<T> matcher) {
return new IsNot<T>(matcher);
return new IsNot<>(matcher);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions hamcrest/src/main/java/org/hamcrest/core/IsNull.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static Matcher<Object> nullValue() {
return new IsNull<Object>();
return new IsNull<>();
}

/**
Expand Down Expand Up @@ -58,7 +58,7 @@ public static Matcher<Object> notNullValue() {
* @return The matcher.
*/
public static <T> Matcher<T> nullValue(Class<T> type) {
return new IsNull<T>();
return new IsNull<>();
}

/**
Expand Down
4 changes: 2 additions & 2 deletions hamcrest/src/main/java/org/hamcrest/core/IsSame.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <T> Matcher<T> sameInstance(T target) {
return new IsSame<T>(target);
return new IsSame<>(target);
}

/**
Expand All @@ -52,7 +52,7 @@ public static <T> Matcher<T> sameInstance(T target) {
* @return The matcher.
*/
public static <T> Matcher<T> theInstance(T target) {
return new IsSame<T>(target);
return new IsSame<>(target);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class NullSafety {

@SuppressWarnings("unchecked")
public static <E> List<Matcher<? super E>> nullSafe(Matcher<? super E>[] itemMatchers) {
final List<Matcher<? super E>> matchers = new ArrayList<Matcher<? super E>>(itemMatchers.length);
final List<Matcher<? super E>> matchers = new ArrayList<>(itemMatchers.length);
for (final Matcher<? super E> itemMatcher : itemMatchers) {
matchers.add((Matcher<? super E>) (itemMatcher == null ? IsNull.nullValue() : itemMatcher));
}
Expand Down
4 changes: 2 additions & 2 deletions hamcrest/src/main/java/org/hamcrest/object/HasToString.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protected String featureValueOf(T actual) {
* @return The matcher.
*/
public static <T> Matcher<T> hasToString(Matcher<? super String> toStringMatcher) {
return new HasToString<T>(toStringMatcher);
return new HasToString<>(toStringMatcher);
}

/**
Expand All @@ -45,7 +45,7 @@ public static <T> Matcher<T> hasToString(Matcher<? super String> toStringMatcher
* @return The matcher.
*/
public static <T> Matcher<T> hasToString(String expectedToString) {
return new HasToString<T>(equalTo(expectedToString));
return new HasToString<>(equalTo(expectedToString));
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void describeTo(Description description) {
* @return The matcher.
*/
public static <T> Matcher<Class<?>> typeCompatibleWith(Class<T> baseType) {
return new IsCompatibleType<T>(baseType);
return new IsCompatibleType<>(baseType);
}

}
2 changes: 1 addition & 1 deletion hamcrest/src/main/java/org/hamcrest/xml/HasXPath.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
public class HasXPath extends TypeSafeDiagnosingMatcher<Node> {

public static final NamespaceContext NO_NAMESPACE_CONTEXT = null;
private static final IsAnything<String> WITH_ANY_CONTENT = new IsAnything<String>("");
private static final IsAnything<String> WITH_ANY_CONTENT = new IsAnything<>("");
private static final Condition.Step<Object, String> NODE_EXISTS = nodeExists();
private final Matcher<String> valueMatcher;
private final XPathExpression compiledXPath;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void testHasAReadableDescription() {

public void testCompilesWithATypedCollection() {
// To prove Issue 43
ArrayList<String> arrayList = new ArrayList<String>();
ArrayList<String> arrayList = new ArrayList<>();
MatcherAssert.assertThat(arrayList, hasSize(0));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ public void testCompiles() {
private void needs(@SuppressWarnings("unused") Matcher<Collection<String>> bar) { }

private static Collection<String> collectionOfValues() {
return new ArrayList<String>(asList("one", "three"));
return new ArrayList<>(asList("one", "three"));
}

private static Collection<Integer> emptyCollection() {
return new ArrayList<Integer>();
return new ArrayList<>();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ public void testCompiles() {
private void needs(@SuppressWarnings("unused") Matcher<Iterable<String>> bar) { }

private static Collection<String> collectionOfValues() {
return new ArrayList<String>(asList("one", "three"));
return new ArrayList<>(asList("one", "three"));
}

private static Collection<Integer> emptyCollection() {
return new ArrayList<Integer>();
return new ArrayList<>();
}

}
8 changes: 4 additions & 4 deletions hamcrest/src/test/java/org/hamcrest/collection/IsInTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ public class IsInTest extends AbstractMatcherTest {

@Override
protected Matcher<?> createMatcher() {
return new IsIn<String>(elements);
return new IsIn<>(elements);
}

public void testReturnsTrueIfArgumentIsInCollection() {
Collection<String> collection = Arrays.asList(elements);
Matcher<String> isIn = new IsIn<String>(collection);
Matcher<String> isIn = new IsIn<>(collection);

assertMatches("a", isIn, "a");
assertMatches("b", isIn, "b");
Expand All @@ -27,7 +27,7 @@ public void testReturnsTrueIfArgumentIsInCollection() {
}

public void testReturnsTrueIfArgumentIsInArray() {
Matcher<String> isIn = new IsIn<String>(elements);
Matcher<String> isIn = new IsIn<>(elements);

assertMatches("a", isIn, "a");
assertMatches("b", isIn, "b");
Expand All @@ -36,7 +36,7 @@ public void testReturnsTrueIfArgumentIsInArray() {
}

public void testHasReadableDescription() {
Matcher<String> isIn = new IsIn<String>(elements);
Matcher<String> isIn = new IsIn<>(elements);

assertEquals("description",
"one of {\"a\", \"b\", \"c\"}",
Expand Down
Loading

0 comments on commit 3929ae3

Please sign in to comment.