Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for an easy way to contribute to Haml? Help us get rid of warnings. #515

Closed
norman opened this issue Apr 29, 2012 · 1 comment
Closed
Milestone

Comments

@norman
Copy link
Contributor

norman commented Apr 29, 2012

Have you ever run your test suite with warnings enabled? If you don't know what I mean, try running almost any library's test suite like this:

RUBYOPT=-w rake test

and behold the thousands of lines of garbage Ruby helpfully spews to stderr. Haml unfortunately has lots of warnings, and I'd like to get rid of as many of them as possible.

Removing warnings is a great way to lean how the codebase works and make a significant contribution to Haml, and it's often pretty easy work. It doesn't require that you give up your weekends or have a degree in computer science. This is actually how @spastorino started working on Rails a few years ago, and now he's one of its main developers.

So if you like Haml and are looking for a good way to get started contributing to the project, I'll be very glad to accept these kinds of contributions.

For a great article on Ruby's warning mode, and what the most common warnings mean, check out @mislav's blog post on the topic.

norman pushed a commit that referenced this issue Apr 29, 2012
See issue #515

Signed-off-by: Norman Clarke <norman@njclarke.com>
This was referenced May 6, 2012
@norman
Copy link
Contributor Author

norman commented Jun 5, 2012

The Haml test suite now emits no warnings, and $VERBOSE is now set to true to stop them from creeping back in in the future. Closing this ticket!

@norman norman closed this as completed Jun 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant