Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BAM to BAI to the TTFI #429

Merged
merged 4 commits into from
Feb 15, 2017
Merged

Add BAM to BAI to the TTFI #429

merged 4 commits into from
Feb 15, 2017

Conversation

tavinathanson
Copy link
Member

Easily convert BAMs to BAIs in a pipeline.

@tavinathanson tavinathanson self-assigned this Feb 15, 2017
@smondet smondet assigned smondet and unassigned tavinathanson Feb 15, 2017
smondet
smondet reviewed Feb 15, 2017
View reviewed changes
Copy link
Member

@smondet smondet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure about the name itself, maybe index_bam is would be more readable than bai?

@tavinathanson
Copy link
Member Author

I think @ihodes recommended bai, I'll defer to you both since I'm less familiar with the words used around this code base.

@ihodes
Copy link
Member

ihodes commented Feb 15, 2017

discussed offline, tl;dr function will be a verb, type remains Bai

@tavinathanson
Copy link
Member Author

Renamed function to index_bam.

@smondet smondet merged commit af4420b into master Feb 15, 2017
smondet added a commit that referenced this pull request Feb 15, 2017
@smondet
Merge PR #429 (@tavinathanson, EDSL.index_bam)
99acfbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smondet smondet smondet left review comments

@ihodes ihodes Awaiting requested review from ihodes

Assignees

@smondet smondet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tavinathanson @ihodes @smondet