Record version in pileup.version #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great - I like the lint check you put in place for this. I also wonder if we can make this part of the build process (something like an automatic header appended to the final file). |
|
I added a jQuery-style preamble to the minified JS. It looks like this: |
danvk
added a commit
that referenced
this pull request
Nov 23, 2015
Record version in pileup.version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be helpful if we ever want to check what version of pileup someone is using, e.g. ourselves on hammerlab.org or someone else on dnanexus.
Nothing ever stays in sync unless you force it to, so I've added a lint check that the two version numbers are the same.