Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically generated vcf content #420

Merged
merged 6 commits into from
Jun 17, 2016
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/main/AbstractFile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/**
* AbstractFile is an abstract representation of a file. There are two implementation:
* 1. RemoteFile - representation of a file on a remote server which can be
* fetched in chunks, e.g. using a Range request.
* 2. LocalStringFile is a representation of a file that was created from input string.
* Used for testing and small input files.
* @flow
*/
'use strict';

//import Q from 'q';

class AbstractFile {
constructor() {
//how to prevent instantation of this class???
//this code doesn't pass npm run flow
// if (new.target === AbstractFile) {
// throw new TypeError("Cannot construct AbstractFile instances directly");
// }
}

getBytes(start: number, length: number):Object {//: Q.Promise<ArrayBuffer> {
throw new TypeError("Method getBytes is not implemented");
}

// Read the entire file -- not recommended for large files!
getAll():Object {//: Q.Promise<ArrayBuffer> {
throw new TypeError("Method getAll is not implemented");
}

// Reads the entire file as a string (not an ArrayBuffer).
// This does not use the cache.
getAllString():Object {//: Q.Promise<string> {
throw new TypeError("Method getAllString is not implemented");
}

// Returns a promise for the number of bytes in the remote file.
getSize():Object {//: Q.Promise<number> {
throw new TypeError("Method getSize is not implemented");
}
}

module.exports = AbstractFile;
66 changes: 66 additions & 0 deletions src/main/LocalStringFile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/**
* LocalStringFile is a representation of a file that was created from input string. Used for testing and small input files.
* @flow
*/
'use strict';

import Q from 'q';
import AbstractFile from './AbstractFile';

class LocalStringFile extends AbstractFile {
fileLength: number;
content: string; //content of this "File"
buffer: ArrayBuffer;

constructor(content: string) {
super();
this.fileLength = content.length;
this.buffer = new ArrayBuffer(content.length); // 2 bytes for each char
this.content = content;

var bufView = new Uint8Array(this.buffer);
for (var i=0; i < this.fileLength; i++) {
bufView[i] = content.charCodeAt(i);
}
}

getBytes(start: number, length: number): Q.Promise<ArrayBuffer> {
if (length < 0) {
return Q.reject(`Requested <0 bytes (${length})`);
}

// If the remote file length is known, clamp the request to fit within it.
var stop = start + length - 1;
if (this.fileLength != -1) {
stop = Math.min(this.fileLength - 1, stop);
}

// First check the cache.
var buf = this.getFromCache(start, stop);
return Q.when(buf);
}

// Read the entire file -- not recommended for large files!
getAll(): Q.Promise<ArrayBuffer> {
var buf = this.getFromCache(0, this.fileLength - 1);
return Q.when(buf);
}

// Reads the entire file as a string (not an ArrayBuffer).
// This does not use the cache.
getAllString(): Q.Promise<string> {
return Q.when(this.content);
}

// Returns a promise for the number of bytes in the remote file.
getSize(): Q.Promise<number> {
return Q.when(this.fileLength);
}

getFromCache(start: number, stop: number): ?ArrayBuffer {
return this.buffer.slice(start, stop + 1);
}

}

module.exports = LocalStringFile;
4 changes: 3 additions & 1 deletion src/main/RemoteFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
'use strict';

import Q from 'q';
import AbstractFile from './AbstractFile';

type Chunk = {
start: number;
Expand All @@ -15,13 +16,14 @@ type Chunk = {
}


class RemoteFile {
class RemoteFile extends AbstractFile{
url: string;
fileLength: number;
chunks: Array<Chunk>; // regions of file that have already been loaded.
numNetworkRequests: number; // track this for debugging/testing

constructor(url: string) {
super();
this.url = url;
this.fileLength = -1; // unknown
this.chunks = [];
Expand Down
6 changes: 3 additions & 3 deletions src/main/data/vcf.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
'use strict';

import type ContigInterval from '../ContigInterval';
import type RemoteFile from '../RemoteFile';
import type AbstractFile from '../AbstractFile';
import type Q from 'q';

export type Variant = {
Expand Down Expand Up @@ -146,10 +146,10 @@ class ImmediateVcfFile {


class VcfFile {
remoteFile: RemoteFile;
remoteFile: AbstractFile;
immediate: Q.Promise<ImmediateVcfFile>;

constructor(remoteFile: RemoteFile) {
constructor(remoteFile: AbstractFile) {
this.remoteFile = remoteFile;

this.immediate = this.remoteFile.getAllString().then(txt => {
Expand Down
23 changes: 19 additions & 4 deletions src/main/sources/VcfDataSource.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import Q from 'q';

import ContigInterval from '../ContigInterval';
import RemoteFile from '../RemoteFile';
import LocalStringFile from '../LocalStringFile';
import VcfFile from '../data/vcf';

export type VcfDataSource = {
Expand Down Expand Up @@ -91,13 +92,27 @@ function createFromVcfFile(remoteSource: VcfFile): VcfDataSource {
return o;
}

function create(data: {url:string}): VcfDataSource {
function create(data: Object): VcfDataSource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using optional field annotations instead? Maybe something like this:

function create(data: {url?: string, content?: string}): VcfDataSource {
  var {url, content} = data;
  if (url) {
    return createFromVcfFile(new VcfFile(new RemoteFile(url)));
  } else if (content) {
    return createFromVcfFile(new VcfFile(new LocalStringFile(content)));
  }
  // If no URL or content is passed, fail
  throw new Error(`Missing URL or content from track: ${JSON.stringify(data)}`);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure,

As I mentioned. I'm not JavaScript developer and Ecmascript 2015 is definitely new to me. I didn't know that I can do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries - I, also, had to check the flow-type reference and try a few things before I get that right. Not the most obvious solution ;)

var url = data.url;
if (!url) {
throw new Error(`Missing URL from track: ${JSON.stringify(data)}`);
var content = data.content;
if (url!==null && url!== undefined) {
return createFromVcfFile(new VcfFile(new RemoteFile(url)));
}
if (content!==null && content!== undefined) {
return createFromVcfFile(new VcfFile(new LocalStringFile(content)));
}
throw new Error(`Missing URL from track: ${JSON.stringify(data)}`);
}

return createFromVcfFile(new VcfFile(new RemoteFile(url)));
function create(data: {url?: string, content?: string}): VcfDataSource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this implementation in. Can you remove the old one from the source code?

var {url, content} = data;
if (url) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs -> spaces

return createFromVcfFile(new VcfFile(new RemoteFile(url)));
} else if (content) {
return createFromVcfFile(new VcfFile(new LocalStringFile(content)));
}
// If no URL or content is passed, fail
throw new Error(`Missing URL or content from track: ${JSON.stringify(data)}`);
}

module.exports = {
Expand Down
113 changes: 113 additions & 0 deletions src/test/LocalStringFile-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
/* @flow */
'use strict';

import {expect} from 'chai';

import LocalStringFile from '../main/LocalStringFile';
import jBinary from 'jbinary';

describe('LocalStringFile', () => {
function bufferToText(buf) {
return new jBinary(buf).read('string');
}

it('should fetch a subset of a file', function() {
var f = new LocalStringFile('0123456789\n');
var promisedData = f.getBytes(4, 5);

return promisedData.then(buf => {
expect(buf.byteLength).to.equal(5);
expect(bufferToText(buf)).to.equal('45678');
});
});

it('should fetch subsets from cache', function() {
var f = new LocalStringFile('0123456789\n');
return f.getBytes(0, 10).then(buf => {
expect(buf.byteLength).to.equal(10);
expect(bufferToText(buf)).to.equal('0123456789');
return f.getBytes(4, 5).then(buf => {
expect(buf.byteLength).to.equal(5);
expect(bufferToText(buf)).to.equal('45678');
});
});
});

it('should fetch entire files', function() {
var f = new LocalStringFile('0123456789\n');
return f.getAll().then(buf => {
expect(buf.byteLength).to.equal(11);
expect(bufferToText(buf)).to.equal('0123456789\n');
});
});

it('should determine file lengths', function() {
var f = new LocalStringFile('0123456789\n');
return f.getSize().then(size => {
expect(size).to.equal(11);
});
});

it('should get file lengths from full requests', function() {
var f = new LocalStringFile('0123456789\n');
return f.getAll().then(buf => {
return f.getSize().then(size => {
expect(size).to.equal(11);
});
});
});

it('should get file lengths from range requests', function() {
var f = new LocalStringFile('0123456789\n');
return f.getBytes(4, 5).then(buf => {
return f.getSize().then(size => {
expect(size).to.equal(11);
});
});
});

it('should cache requests for full files', function() {
var f = new LocalStringFile('0123456789\n');
f.getAll().then(buf => {
expect(buf.byteLength).to.equal(11);
expect(bufferToText(buf)).to.equal('0123456789\n');
return f.getAll().then(buf => {
expect(buf.byteLength).to.equal(11);
expect(bufferToText(buf)).to.equal('0123456789\n');
});
});
});

it('should serve range requests from cache after getAll', function() {
var f = new LocalStringFile('0123456789\n');
return f.getAll().then(buf => {
expect(buf.byteLength).to.equal(11);
expect(bufferToText(buf)).to.equal('0123456789\n');
return f.getBytes(4, 5).then(buf => {
expect(buf.byteLength).to.equal(5);
expect(bufferToText(buf)).to.equal('45678');
});
});
});

it('should truncate requests past EOF', function() {
var f = new LocalStringFile('0123456789\n');
var promisedData = f.getBytes(4, 100);

return promisedData.then(buf => {
expect(buf.byteLength).to.equal(7);
expect(bufferToText(buf)).to.equal('456789\n');
return f.getBytes(6, 90).then(buf => {
expect(buf.byteLength).to.equal(5);
expect(bufferToText(buf)).to.equal('6789\n');
});
});
});

it('should fetch entire files as strings', function() {
var f = new LocalStringFile('0123456789\n');
return f.getAllString().then(txt => {
expect(txt).to.equal('0123456789\n');
});
});
});
47 changes: 32 additions & 15 deletions src/test/data/vcf-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,43 @@ import {expect} from 'chai';
import VcfFile from '../../main/data/vcf';
import ContigInterval from '../../main/ContigInterval';
import RemoteFile from '../../main/RemoteFile';
import LocalStringFile from '../../main/LocalStringFile';

describe('VCF', function() {
it('should respond to queries', function() {
var vcf = new VcfFile(new RemoteFile('/test-data/snv.vcf'));
var range = new ContigInterval('20', 63799, 69094);
return vcf.getFeaturesInRange(range).then(features => {
expect(features).to.have.length(6);
describe('should respond to queries', function() {
var testQueries = (vcf) => {
var range = new ContigInterval('20', 63799, 69094);
return vcf.getFeaturesInRange(range).then(features => {
expect(features).to.have.length(6);

var v0 = features[0],
v5 = features[5];

var v0 = features[0],
v5 = features[5];
expect(v0.contig).to.equal('20');
expect(v0.position).to.equal(63799);
expect(v0.ref).to.equal('C');
expect(v0.alt).to.equal('T');

expect(v0.contig).to.equal('20');
expect(v0.position).to.equal(63799);
expect(v0.ref).to.equal('C');
expect(v0.alt).to.equal('T');
expect(v5.contig).to.equal('20');
expect(v5.position).to.equal(69094);
expect(v5.ref).to.equal('G');
expect(v5.alt).to.equal('A');
});
};

var remoteFile = new RemoteFile('/test-data/snv.vcf');

it('remote file', function() {
var vcf = new VcfFile(remoteFile);
testQueries(vcf);
});

expect(v5.contig).to.equal('20');
expect(v5.position).to.equal(69094);
expect(v5.ref).to.equal('G');
expect(v5.alt).to.equal('A');
it('local file from string', function() {
return remoteFile.getAllString().then(content => {
var localFile = new LocalStringFile(content);
var vcf = new VcfFile(localFile);
testQueries(vcf);
});
});
});

Expand Down