Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one logger per module #171

Merged
merged 4 commits into from
Oct 10, 2016
Merged

one logger per module #171

merged 4 commits into from
Oct 10, 2016

Conversation

julia326
Copy link
Contributor

@julia326 julia326 commented Oct 4, 2016 •
edited

fixes #170, #172

This change is Reviewable

@ihodes
Copy link
Contributor

ihodes commented Oct 4, 2016

LGTM, thanks for doing these changes! 👍

@coveralls
Copy link

coveralls commented Oct 4, 2016 •
edited

Coverage Status

Coverage decreased (-0.06%) to 81.395% when pulling 1cb92ba on pyensembl-logger into 98b61b2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 81.331% when pulling 0a637a2 on pyensembl-logger into 98b61b2 on master.

@coveralls
Copy link

coveralls commented Oct 4, 2016 •
edited

Coverage Status

Coverage decreased (-0.04%) to 81.419% when pulling 2cb4bb3 on pyensembl-logger into 98b61b2 on master.

@julia326
One logger per module, and associated changes:
64c6962 
- adding a logging.conf file that sets up logging configuration for pyensembl and packages it calls
@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited

Coverage Status

Coverage decreased (-0.2%) to 81.27% when pulling 64c6962 on pyensembl-logger into 98b61b2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 81.205% when pulling 303068c on pyensembl-logger into 98b61b2 on master.

@coveralls
Copy link

coveralls commented Oct 7, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 81.319% when pulling 75dccf3 on pyensembl-logger into 98b61b2 on master.

@julia326 julia326 merged commit 12f2fec into master Oct 10, 2016
@julia326 julia326 deleted the pyensembl-logger branch October 10, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iskandr iskandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One logger per module
4 participants
@julia326 @ihodes @coveralls @iskandr