Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has undefined error #37

Closed
y0hami opened this issue Jan 31, 2019 · 0 comments
Closed

has undefined error #37

y0hami opened this issue Jan 31, 2019 · 0 comments
Assignees
@y0hami
Labels
bug Something isn't working

Comments

@y0hami
Copy link
Owner

y0hami commented Jan 31, 2019

.has() throws an error when checking an object which doesn't have a property
image
@y0hami y0hami added the bug Something isn't working label Jan 31, 2019
@y0hami y0hami self-assigned this Jan 31, 2019
y0hami pushed a commit that referenced this issue Feb 5, 2019
fix(has): bug causing cannot read property error
2e5bd9b 
The has function wasn't checking if the current iteration value
was an object before it would try and grab a value from it therefore
it would throw a "Cannot read property X of undefined" error

Fixes #37
y0hami pushed a commit that referenced this issue Feb 5, 2019
test(has): add new test for undefined path
34824ca 
Add a test which should fail if #37 returns. The test should
return false if the full path specified doesn't exist in the
object provided.
@y0hami y0hami closed this as completed in 784d4d8 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y0hami y0hami

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@y0hami