Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different naming scheme? #2

Open
jhmartin opened this issue Jul 24, 2019 · 2 comments
Open

Different naming scheme? #2

jhmartin opened this issue Jul 24, 2019 · 2 comments

Comments

@jhmartin
Copy link

It looks like this tool registers the container by the ecs name instead of looking at the SERVICE_XYZ_NAME variable / labels; if so that should probably be listed under the 'main differences' block in the documentation.

@hampsterx
Copy link
Owner

hi there, yes that's right. Happy to modify to use ENV vars as primary option if you would find that useful?
This tool was built for my own needs, it's actively used, open source mostly so I didn't have to deal with private pypi.

@jhmartin
Copy link
Author

jhmartin commented Jul 24, 2019

No need to do that yet. I followed the link from the gliderlabs repo over here, if others do they also might be confused. I think fleshing out the README a skosh with how this version operates is fine -- the py is fine enough that if I end up using it I can add that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants