Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DI container interface traits #14

Closed
HampusMat opened this issue Aug 16, 2023 · 1 comment
Closed

Remove DI container interface traits #14

HampusMat opened this issue Aug 16, 2023 · 1 comment
Labels
enhancement A general improvement suggestion

Comments

@HampusMat
Copy link
Owner

The traits IDIContainer and IAsyncDIContainer should be removed. They were created so that DIContainer and AsyncDIContainer can be mocked but it's much more ergonomic to just replace the whole struct. I don't know why i didn't do it that way.
@HampusMat HampusMat added the enhancement A general improvement suggestion label Aug 16, 2023
@HampusMat HampusMat added this to the v0.5.0 milestone Aug 17, 2023
@HampusMat
Copy link
Owner Author

It doesn't work when structs which uses a DI container sometimes should get a mocked version and sometimes not

@HampusMat HampusMat removed this from the v0.5.0 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general improvement suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HampusMat