Bookstore: initialize project with components #1
Conversation
There was a problem hiding this comment.
Hi @Hamzaoutdoors, 🖐
Good job so far!
- Good Readme 👌
- Well descriptive PR 👌
- Good commits 👌
- Good implementation of the requirements and good code organization 💪
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/Form.js
Outdated
| <Form> | ||
| <Row className="mb-4"> | ||
| <Col xs={7} controlId="formGridCity"> | ||
| <Form.Control placeholder="Book title" /> | ||
| </Col> | ||
|
|
||
| <Form.Group as={Col} controlId="formGridState"> | ||
| <Form.Select defaultValue="Category"> | ||
| <option>Category</option> | ||
| <option>Action</option> | ||
| <option>Drama</option> | ||
| <option>Romance</option> | ||
| </Form.Select> | ||
| </Form.Group> | ||
| <Button as={Col} variant="primary" type="submit"> | ||
| ADD BOOK | ||
| </Button> | ||
| </Row> | ||
| </Form> |
There was a problem hiding this comment.
- You are missing another
form.Controlhere, the one for theauthorof the book. A book has three attributes which aretitle, author, and category. Let's add it and everything should be working fine!🙂
There was a problem hiding this comment.
Thank you for your review I add the author input. I don't see the author case in the design because of that I didn't add it 😄
There was a problem hiding this comment.
Hi @Hamzaoutdoors 🙋♀️,
STATUS APPROVED ✔
Thanks for making the requested change 👏
Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers 🥂 and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thanks @AshakaE for your feedback 😃 |
In this project milestone I accomplished the following :
Thank you in advance for your feedback 😄
Live Demo Link