Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard - Project setup #1

Merged
merged 9 commits into from
Aug 31, 2021
Merged

Leaderboard - Project setup #1

merged 9 commits into from
Aug 31, 2021

Conversation

Hamzaoutdoors
Copy link
Owner

@Hamzaoutdoors Hamzaoutdoors commented Aug 31, 2021

In this Milestone : Project setup

I was able to complete the following:

  • Set up .github/workflows linters to check and fix linters errors for HTML/CSS/JavaScript.
  • Set up the project with webpack that is based on the webpack exercise completed.
  • Create an index.html file and write HTML markup, using the HTML Webpack Plugin.
  • Create an index.js file and set an array of some simple players (array of objects). That can be dynamically displayed with
    • name [string]
    • score [number]
  • Work with ES6 syntax
  • Create a style.css and set rules for the LeaderBoard, loaded by Webpack Style/CSS Loader.
  • All my source files (index.html, index.js, and style.css) is located in the/src directory and distribution files are generated and served by webpack.
  • Fix all linters errors

Copy link

@arslanbisharat arslanbisharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👏

Hi there,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of code reviews per project which you can see from your dashbaord. If you think that the code review was not fair, you can request a second opinion using this form

@Hamzaoutdoors Hamzaoutdoors merged commit 745767b into dev Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants