Settings: use dry-configurable #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waiting-for-dev could you rebase this? I've improved CI setup in the unstable branch. |
This is a baby step towards the to-be-defined level of integration we want between hanami settings and dry-configurable. This commit introduces the minimal changes to keep the very same features we're supporting on the hanami settings side while still delegating to dry-configurable what it's already capable of handling: - dry-configurable is responsible for the setter/getter methods. - Hanami settings resolve the value through a type constructor, when present, before delegating it to dry-configurable. - Hanami settings wrap the definition of all the settings to detect all errors at once instead of failing on a one-by-one basis. Further integration can include delegating the type constructor to a processor keyword argument (we could already delegate it to the block, but probably we want to do the former) and provide an error handler to the whole definition.
waiting-for-dev
force-pushed
the
port_to_dry_configurable
branch
from
d23a0b1
to
700c525
Compare
Done @solnic |
|
Closing in favor of #1114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1105
Uses dry-configurable for the hanami settings.
We have broken apart what is the storage for the settings (ENV with dotenv enabled in our case) from what we actually do to load the settings in the config class. Both the store and the loader are configurable. Users could provide their own store as long as it implements the
#fetchmethod. As for the loader, we can discuss whether it makes any sense to be injectable, as its behavior is very private, relying on dry-configurable dependency.