Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: use dry-configurable #1110

Closed
wants to merge 5 commits into from
Closed

Settings: use dry-configurable #1110

wants to merge 5 commits into from

Commits on Jun 7, 2021

  1. Use dry-configurable for hanami settings 

    This is a baby step towards the to-be-defined level of integration we
want between hanami settings and dry-configurable.

This commit introduces the minimal changes to keep the very same
features we're supporting on the hanami settings side while still
delegating to dry-configurable what it's already capable of handling:

- dry-configurable is responsible for the setter/getter methods.
- Hanami settings resolve the value through a type constructor, when
  present, before delegating it to dry-configurable.
- Hanami settings wrap the definition of all the settings to detect all
  errors at once instead of failing on a one-by-one basis.

Further integration can include delegating the type constructor to a
processor keyword argument (we could already delegate it to the block,
but probably we want to do the former) and provide an error handler to
the whole definition.
    @waiting-for-dev
    waiting-for-dev committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f891d69 View commit details
    Browse the repository at this point in the history

  2. Use dry-configurable directly

    @timriley @waiting-for-dev
    timriley authored and waiting-for-dev committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    125c8e3 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @waiting-for-dev
    waiting-for-dev committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    4f6cdbc View commit details
    Browse the repository at this point in the history

  4. Break settings loader/store apart and allow the configuration of both

    @waiting-for-dev
    waiting-for-dev committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ac1446c View commit details
    Browse the repository at this point in the history

  5. Use new recommended default: kwarg in settings

    @waiting-for-dev
    waiting-for-dev committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    700c525 View commit details
    Browse the repository at this point in the history