submit helper does not accept block syntax

[nerdinand]

The submit form helper does not seem to accept the block syntax for nesting tags within. Example:

            = form_for :run, routes.unlock_run_path(run_id), method: :post do
              - submit nil, class: 'btn btn-outline-success' do
                - span class: 'oi oi-check'

leads to:

<form action="/runs/1/unlock" method="POST" accept-charset="utf-8" id="run-form">
<input name="_csrf_token" value="..." type="hidden">
<button type="submit" class="btn btn-outline-success"></button>
</form>

Whereas the button helper reacts differently (note the nested span in the html):

            = form_for :run, routes.lock_run_path(run_id), method: :post do
              - button nil, class: 'btn btn-outline-success' do
                - span class: 'oi oi-check'

yields:

<form action="/runs/3/lock" method="POST" accept-charset="utf-8" id="run-form">
<input name="_csrf_token" value="..." type="hidden">
<button class="btn btn-outline-success">
<span class="oi oi-check"></span>
</button>
</form>

Is this by design or a bug?

[AlfonsoUceda]

Hi @nerdinand

I've checked that submit doesn't support a block. In my opinion, I suppose we need to support that because as you example, we could add span tags for adding some CSS rule.

It isn't a bug so I'll mark this issue as enhancement. I'll add as soon as possible ;)

[mereghost]

I was doing the exact same thing by passing the span helper as the button text.

[jodosha]

Implemented by #130