Make application context aware of its provider #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timriley I'll leave this to your expertise 🙂 |
timriley
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Looks good, @waiting-for-dev, thank you! Would you mind making that one minor tweak before merging? Happy for you to merge right after :)
| private | ||
|
|
||
| def define_initialize | ||
| resolve_inflector = method(:resolve_inflector) |
There was a problem hiding this comment.
Suggested change
| resolve_inflector = method(:resolve_inflector) | |
| inflector = application.inflector |
Might be worth keeping this simple and only moving to a method if the complexity grows?
There was a problem hiding this comment.
Makes sense, @timriley, done!!
It allows us to extract information depending on the given provider (slice vs. application). Plus, it makes it consistent with the application view and controller.
waiting-for-dev
force-pushed
the
waiting-for-dev/context_provider
branch
from
308d168
to
aef56f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows us to extract information depending on the given provider
(slice vs. application). Plus, it makes it consistent with the application
view and controller.