Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet creation of zero-bid transactions #463

Closed
randomlogin opened this issue May 31, 2020 · 1 comment · Fixed by #479
Closed

Wallet creation of zero-bid transactions #463

randomlogin opened this issue May 31, 2020 · 1 comment · Fixed by #479

Comments

@randomlogin
Copy link

randomlogin commented May 31, 2020

Description: hsw allows creation of zero-bid transaction without any notification that this transaction will not be accepted.

The created transaction can be seen in the wallet's pending transactions list, however the node will not accept it due to dust limits (the transaction itself has nonzero fee), so it will not be seen in node's own mempool and not relayed to anyonel.

Reproducing: hsw-cli rpc sendbid <name> 0 0

Expected behaviour. Either of these:

  1. Tell the user that transaction fails verification, nevertheless create the transaction.
  2. Fail to create the transaction if some special flag like '--ignore-validation-rules` is not passed.

Related issues:
#460 Allow bid and lockup with 0 value in wallet-http
#441 wallet: do check covenants for dust in createTX.

@randomlogin randomlogin changed the title Zero-bid transactions Wallet creation of zero-bid transactions May 31, 2020
@pinheadmz
Copy link
Member

pinheadmz commented May 31, 2020

Thanks @randomlogin

Issues like this have come up before and it's because bcoin and hsd wallet ignore standardness errors when sending TXs.

https://github.com/handshake-org/hsd/blob/master/lib/node/fullnode.js#L327-L353

I've never been a fan of this logic, I think it was written for a problem purse had with bcoin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants