-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
The commit includes following changes: * Upgrade dependencies; * Upgrade the process of building the dist files. The package from now on should be ready for ECMAModules spec.
The label declaration syntax causes transpilation errors. As it is not used by the parser it is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected. By the way, I've noticed a few tiny things:
- lockfile version is bumped to V2 - maybe we should add npm's min version in
engines
entry inpackage.json
?
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2.
-
On Win10 I had a problem with EOL - I guess
.gitattributes
file should solve the problem. -
On Win10/macOS10.15, npm 7.3.0, node15.4.0 I got 4 failure in tests - all of them are related to floated numbers precision (I guess it's
@handsontable/formulajs
issue) -
Should we adjust
@handsontable/formulajs
package? At the moment we import dynamically required files from@handsontable/formulajs/index.js
(it's amain
entry point for that package). It is the "dual package hazard" we try to avoid, isn't it?
But I think the above list is not required to finish this PR - it's up to you 🙂
Well done @budnix!
In includes: * Regenerate the package-lock.json file compatible with Node v10; * Add .gitattributes file;
Thanks for the review :)
I recreated the file (771b36b) to be compatible with the NodeJS version used within the project (v10).
I've added the file in this commit 771b36b.
Yes, depends on used the NodeJS version the precision differs. So far I have added to the contributing.md file a point that describes the NodeJS version requirement.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The PR improves how the distributed files are published to the NPM. From now on, the module should support not only Node
require
syntax butimport
syntax as well. The changes forced a dependency upgrade.The dist files are tested using different bundlers and environments. The following bundlers are tested:
require
andimport
syntax.