Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handsontable missing rows when using preventOverflow with updateSettings #4303

Closed
Tracked by #62
randyyaj opened this issue Jun 7, 2017 · 6 comments
Closed
Tracked by #62

Comments

@randyyaj
Copy link

randyyaj commented Jun 7, 2017

Description

Should see 100 rows in example. I have enabled preventOverflow: horizontal and columnSorting: true. If you remove the columnSorting property it will display all 100 rows.

Steps to reproduce

https://jsfiddle.net/v364ow5o/1/

Demo

https://jsfiddle.net/v364ow5o/1/

Your environment

  • Handsontable version: 0.32.0
  • Browser Name and version: Chrome
  • Operating System: Mac,Linux,Windows
@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 23, 2017

Thank you for sharing this issue. I have replicated the bug.

inform gr handsontable/handsontable#8922

@fengkaijia
Copy link

fengkaijia commented Sep 7, 2017

+1 on 0.34.1. Break down parameters one-by-one and found only preventOverflow and columnSorting cannot co-exist.

@AMBudnik
Copy link
Contributor

I've just replicated it with v 2.0.0. It looks like the issue is as old as preventOverflow itself.

@AMBudnik
Copy link
Contributor

AMBudnik commented Oct 4, 2018

Works the same in v 6.0.1.

@wojciechczerniak
Copy link
Contributor

As noted in #4507 rendering breaks on updateSettings, another example here: https://jsfiddle.net/sw7aryjo/

ColumnSorting have to call updateSettings to enable observeChanges plugin. We will remove observeChanges from ColumnSorting in handsontable/dev-handsontable#167. But the problem with updateSettings will exist.

@wojciechczerniak wojciechczerniak changed the title Handsontable missing rows when using preventOverflow with columnSorting Handsontable missing rows when using preventOverflow with updateSettings Feb 14, 2019
@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 11, 2020

Hi @randyyaj @fengkaijia @jsenbergs

this demo https://jsfiddle.net/auqb2dr5/ loads the latest version of Handsontable - v8.0.0 which allows us to see all the 100 rows and use columnSorting. I'm glad to call this issue solved.

ps. It did not work in v 7.4.2 https://jsfiddle.net/jo6p502q/

mrpiotr-dev added a commit that referenced this issue Oct 20, 2020
mrpiotr-dev pushed a commit that referenced this issue Oct 29, 2020
* #7171 - Adds missing test for #4303

* #7171 - Removes unnecessary E2E test file for hiddenColumns

* #7171 - Adds missing test case for #5207

* #7171 - Adds missing test cases for #3978

* #7171 - Fixes lint errors

* #7171 - Adds missing test cases for #7043

* #7171 - Adds missing test cases for #5000

* #7171 - Adds missing test cases for #5906

* Adds missing tests for #4897

* Changed test for #4897 so thay they only pass in version 8+

* Fixes tests for #4897

* #7171 - Adjustment missing test cases for #4897

* #7171 - Adds missing tests for #6670 and a missing legend for header selection symbols

* #7171 - Adjustment test cases of ##4897 for eslint

* #7171 - Adds missing tests for #7099

* #7171 - Fix linter errors in tests for #7099

* #7171 - Adds missing tests to #7095

* #7171 - Adds missing test cases for #7097

* #7171 - Adds missing expect to tests for #7095

* #7171 - Adds missing test for #6843

* #7171 - Adds missing tests for #7076

* #7171 - Adds missing tests for #6435

* #7171 - Adds missing tests for #3726

* #7171 - Adds missing test cases for #5849

* #7171 - Adds missing tests for #4154

* #7171 - Adjustment on test cases for #5849

* #7171 - Adds missing tests for #6433

* #7171 - Adds missing test cases for #6355

* Fix typo in comment

* #7171 - Adds missing tests for #6386

* #7171 - Adds missing tests for #6831

* #7171 - Adds missing tests for #6363

* #7171 - Adds missing tests for #4999

* #7171 - Adds missing tests for #6426

* #7171 - Adds missing tests for #6113

* #7171 - Adds missing tests for #6412

* #7171 - Adds missing tests for #6310

* #7171 - Adds missing test cases for #5877

* #7171 - Adds missing test for #5824

* #7171 - Adds missing tests for #4713

* #7171 - Adds missing tests for #4576

* #7171 - Changes spec description for #4576

* #7171 - Adds missing test cases for #4601

* #7171 - Adjustment on test cases for #4601

* #7171 - Reverts added tests for #5824 due to a bug #7355

* #7171 - Adds comment with @todo after removing ObserveChanges

Co-authored-by: ndemytruk <ndemytruk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants