[1.16.0+] disableVisualSelection doesn't work via cells method

[AMBudnik]

Description

Since v 1.16.0 we are not able to set disableVisualSelection via cell properties.
It works for the whole instance > http://jsfiddle.net/xb6bemq6/

Steps to reproduce

1. Go to http://jsfiddle.net/aa93rdrx/ (1.16.0)
2. Select any cell in column B

Result: Cell is selected
Expected: Cell should be selected.

setCellMeta demo

1. Go to broken 1.16.0 demo > http://jsfiddle.net/zqr2gbws/
2. Select cell 0,0

Result: Cell is selected
Expected: Cell should be selected like here http://jsfiddle.net/f2pxrdw4/ working 1.15.1.;

Your environment

• Handsontable version: 1.16.0+
  Last working 1.15.1
• Browser Name and version: Chrome 65
• Operating System: Windows 10

Inform GR#14337

[bigsweater]

It seems as though disableVisualSelection works only on the whole table -- it doesn't work at all for columns, either.

Here's the commit that introduced the bug, according to git bisect:

592eae3

Related issues: #4708

And a diff between the last good commit and first bad commit:

505846f...592eae3

[AMBudnik]

Thank you for doing the investigation @bigsweater

[supra28]

@AMBudnik Any ETA on this?

[AMBudnik]

The Roadmap for Q4/2019 is already full and we do not know (yet) what are plans for 2020, but regression type of bugs are usually those which has to be fixed first. Please stay tuned.

[AMBudnik]

Works the same using v 8.0.0-beta 1
Demo https://codesandbox.io/s/misty-dawn-ooh7t

[wszymanski]

Since 1.16.0 there is also problem with option disableVisualSelection, also when it is set globally (for the whole table) just with current value (as an array's element or string; it's one from the possibilities mentioned in documentation). It's also regression.

Before

before.mp4

After

after.mp4

edit: There is similar or the same bug described by our user within #5869. I will fix it within the issue.

[aninde]

This bug has been fixed on v8.3.2.
Thankfully to the hard work of @wszymanski, we improved the operation of this functionality.

disableVisualSelection works at any level of the cascade settings, ie for the entire table, for specific cells in each columns or specific cells.

In this context, each cell has an association with their coordinates: x row and y columns, which may have X and Y headers.
As part of the cells option, we set a cell with the x and y coordinates whether it should highlight the header X and Y.

disableVisualSelection can be:

• assigned only the selected cell headers (header) example https://jsfiddle.net/35atjkzx/

• assigned to selected cell border (current) example https://jsfiddle.net/jqxonc3b/

• assigned to selected area (area) example https://jsfiddle.net/g9r1t82y/1/

• assigned to all the above-mentioned options with disableVisualSelection: true Grey cell C1 example https://jsfiddle.net/nt47c3jw/

Tested on
macOS 11.2.2 (20D80) - Chrome 88.0.4324.192, Safari 14.0.3 (16610.4.3.1.4), Firefox 86.0 , Edge 89.0.774.48, Opera 74.0.3911.203
Windows 10 - Chrome 88.0.4324.192 , Edge 89.0.774.48, IE 11, Firefox 86.0.

[AMBudnik]

Thank you for solving this case. We can close the issue as solved for v8.3.2 of Handsontable.

@bigsweater @supra28 if you'd be still experiencing this issue after updating to v8.3.2 please let me know.