Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableVisualSelection doesn't work for headers #6025

Closed
mrpiotr-dev opened this issue May 21, 2019 · 6 comments
Closed

disableVisualSelection doesn't work for headers #6025

mrpiotr-dev opened this issue May 21, 2019 · 6 comments

Comments

@mrpiotr-dev
Copy link
Contributor

mrpiotr-dev commented May 21, 2019

Description

disableVisualSelection doesn't work for headers. It doesn't matter if we set 'header' or true - headers will be highlighted.

Related issue: #5869

Steps to reproduce

  1. Initialize Handsontable with the following configuration:
rowHeaders: true,
colHeaders: true,
disableVisualSelection: true,
  1. Select column A or 2nd row by a header.

Demo

https://jsfiddle.net/handsoncode/8ffpsqt6/

Your environment

  • Handsontable version: 2.0.0+
  • Browser Name and version: any
  • Operating System: any
@aninde
Copy link
Contributor

aninde commented Jul 7, 2020

This bug can be replicable with 8.0.0-beta2-rev19 https://jsfiddle.net/aninde/92wa1txc/

@pnowak
Copy link
Contributor

pnowak commented Sep 9, 2020

This issue is still replicable using v8.0.0. Here's an updated demo - https://jsfiddle.net/xvq9yw8u/

@AMBudnik
Copy link
Contributor

AMBudnik commented Jan 21, 2021

It works for me (header is not highlighted when we use disableVisualSelection: 'header') on Chrome 87/Firefox 84/Edge (Windows 10) using v7.4.2 and newer https://jsfiddle.net/handsoncode/6m1j5kxd/

image

EDIT: I've just tested it with macOS Catalina and Chrome. Also works fine.

@wszymanski
Copy link
Contributor

wszymanski commented Jan 21, 2021

It works for me (header is not highlighted when we use disableVisualSelection: 'header') on Chrome 87/Firefox 84/Edge (Windows 10) using v7.4.2 and newer jsfiddle.net/handsoncode/6m1j5kxd

image

EDIT: I've just tested it with macOS Catalina and Chrome. Also works fine.

The issue is addressing problem only for clicks on headers :) The disableVisualSelection option set to value 'header' works properly for clicks on cells now.

@aninde
Copy link
Contributor

aninde commented Mar 10, 2021

This bug has been fixed on v8.3.2. https://jsfiddle.net/e19odr0g/.
Setting disableVisualSelection on true or on header causes the inability to select headers.

More information examples of working disableVisualSelection can be found here.

@AMBudnik
Copy link
Contributor

I'm closing this issue as solved and released under Handsontable v8.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants