Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra parameters for the hiddenRows and hiddenColumns plugin's existing hooks #5671

Closed
wszymanski opened this issue Dec 14, 2018 · 0 comments
Closed

Add extra parameters for the hiddenRows and hiddenColumns plugin's existing hooks #5671

wszymanski opened this issue Dec 14, 2018 · 0 comments
Assignees
@wszymanski
Labels
enhancement Hiding Plugin Status: Released
Milestone
December 2018

Comments

@wszymanski
Copy link
Contributor

wszymanski commented Dec 14, 2018 •
edited

@wszymanski commented on Fri Dec 07 2018

Description

Hooks for hiding / unhiding rows and columns should have the following parameters:

  • currentHideConfig
  • destinationHideConfig
  • hidePossible / unhidePossible
  • stateChanged

Related issue(s):

  1. Add hooks to the hiddenRows and hiddenColumns plugins. handsontable-pro#165
  2. Add the HiddenRows-related hooks to pluginHooks.js #5522
@wszymanski wszymanski self-assigned this Dec 14, 2018
wszymanski added a commit that referenced this issue Dec 14, 2018
@wszymanski
Refactor #5671
9b8893b
wszymanski added a commit that referenced this issue Dec 14, 2018
@wszymanski
Changes in hiddenRows plugin #5671
7e29ff9
wszymanski added a commit that referenced this issue Dec 14, 2018
@wszymanski
Changes in hiddenColumns plugin #5671
f96d4eb
@wszymanski wszymanski mentioned this issue Dec 17, 2018
Merged
6 tasks
@wszymanski wszymanski added this to the December 2018 milestone Dec 17, 2018
wszymanski added a commit that referenced this issue Jan 16, 2019
@wszymanski
Reverted old way of plugin work #5671
7054e33
wszymanski added a commit that referenced this issue Jan 16, 2019
@wszymanski
Additional test #5671
534e907
wszymanski added a commit that referenced this issue Jan 16, 2019
@wszymanski
Updated test #5671
600b0df
wszymanski added a commit that referenced this issue Jan 16, 2019
@wszymanski
Typo #5671
995382a
wszymanski added a commit that referenced this issue Jan 17, 2019
@wszymanski
Added hooks type definition and fix for bad trimRows hooks #5671
8f907c2
wszymanski added a commit that referenced this issue Jan 25, 2019
@wszymanski
Missing types & documentation #5671
88399ef
wszymanski added a commit that referenced this issue Jan 25, 2019
@wszymanski
Missing part of code #5671
9741ad9
@wszymanski wszymanski changed the title Add extra parameters for the hiddenRows plugin's existing hooks Add extra parameters for the hiddenRows and hiddenColumns plugin's existing hooks Jan 25, 2019
wszymanski added a commit that referenced this issue Jan 25, 2019
@wszymanski
Add extra parameters for the hiddenRows and hiddenColumns plugin'…
f5d8762 
…s existing hooks (#5677)

* Refactor #5671

* Changes in hiddenRows plugin #5671

* Changes in hiddenColumns plugin #5671

* Reverted old way of plugin work #5671

* Additional test #5671

* Updated test #5671

* Typo #5671

* Added hooks type definition and fix for bad trimRows hooks #5671

* Missing types & documentation #5671

* Missing part of code #5671
@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
enhancement Hiding Plugin Status: Released
Projects
None yet
Milestone
December 2018
Development

No branches or pull requests
3 participants
@wszymanski @jansiegel @AMBudnik