Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra parameters for the `hiddenRows` and `hiddenColumns` plugin's existing hooks #5671

Closed
wszymanski opened this Issue Dec 14, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@wszymanski
Copy link
Member

wszymanski commented Dec 14, 2018

@wszymanski commented on Fri Dec 07 2018

Description

Hooks for hiding / unhiding rows and columns should have the following parameters:

  • currentHideConfig
  • destinationHideConfig
  • hidePossible / unhidePossible
  • stateChanged

Related issue(s):

  1. handsontable/handsontable-pro#165
  2. #5522

@wszymanski wszymanski self-assigned this Dec 14, 2018

wszymanski added a commit that referenced this issue Dec 14, 2018

wszymanski added a commit that referenced this issue Dec 14, 2018

wszymanski added a commit that referenced this issue Dec 14, 2018

@wszymanski wszymanski added this to the December 2018 milestone Dec 17, 2018

wszymanski added a commit that referenced this issue Jan 16, 2019

wszymanski added a commit that referenced this issue Jan 16, 2019

wszymanski added a commit that referenced this issue Jan 16, 2019

wszymanski added a commit that referenced this issue Jan 16, 2019

wszymanski added a commit that referenced this issue Jan 17, 2019

wszymanski added a commit that referenced this issue Jan 25, 2019

wszymanski added a commit that referenced this issue Jan 25, 2019

@wszymanski wszymanski changed the title Add extra parameters for the `hiddenRows` plugin's existing hooks Add extra parameters for the `hiddenRows` and `hiddenColumns` plugin's existing hooks Jan 25, 2019

wszymanski added a commit that referenced this issue Jan 25, 2019

Add extra parameters for the `hiddenRows` and `hiddenColumns` plugin'…
…s existing hooks (#5677)

* Refactor #5671

* Changes in hiddenRows plugin #5671

* Changes in hiddenColumns plugin #5671

* Reverted old way of plugin work #5671

* Additional test #5671

* Updated test #5671

* Typo #5671

* Added hooks type definition and fix for bad trimRows hooks #5671

* Missing types & documentation #5671

* Missing part of code #5671

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.