Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering "handsontable" cell type header handles won't throw an error #10458

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

wszymanski
Copy link
Contributor

@wszymanski wszymanski commented Aug 2, 2023

Context

It seems that mouseover event attached to HOT's root element is executed twice when we have HOT in HOT element. One event is called for the main instance and the second one for editor being a Handsontable. Callback in one from the cases is trying to overwrite private variables (related to main instance) which shouldn't be touched.

HOT in HOT will handle it's callback by its own anyway. Thus, this PR adds an extra conditional which checks whether callback should be executed.

How has this been tested?

Tested case from the issue, another from #10359, HOT with table in a column header, checked whether ContextMenu work properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. [8.0.0+] Hovering handsontable cell type header handles throws an error #9317
  2. Hovering embedded table header cell crashes the app #10359

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
  • My change requires a change to the documentation.

@wszymanski wszymanski self-assigned this Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Launch the local version of documentation by running:

npm run docs:review 2ec84e655d2733b3de6c71218c9ece31bd12a441

@wszymanski wszymanski merged commit baf2fcf into develop Aug 9, 2023
23 checks passed
@wszymanski wszymanski deleted the feature/issue-dev-519 branch August 9, 2023 11:44
jansiegel added a commit that referenced this pull request Aug 29, 2023
jansiegel added a commit that referenced this pull request Aug 29, 2023
jansiegel added a commit that referenced this pull request Aug 29, 2023
- Rebuild after the revert of #10458
- Remove the #10458 entry from changelog and release notes.
jansiegel added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants