Hovering "handsontable" cell type header handles won't throw an error #10458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It seems that
mouseover
event attached to HOT's root element is executed twice when we have HOT in HOT element. One event is called for the main instance and the second one for editor being a Handsontable. Callback in one from the cases is trying to overwrite private variables (related to main instance) which shouldn't be touched.HOT in HOT will handle it's callback by its own anyway. Thus, this PR adds an extra conditional which checks whether callback should be executed.
How has this been tested?
Tested case from the issue, another from #10359, HOT with table in a column header, checked whether
ContextMenu
work properly.Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: