Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering "handsontable" cell type header handles won't throw an error #10761

Merged
merged 4 commits into from Feb 9, 2024

Conversation

wszymanski
Copy link
Contributor

@wszymanski wszymanski commented Jan 31, 2024

Context

The fix provided within PR #10458 has been reverted. I tried to fix the problems found after the release. However, after investigation, I suggested new changes. Probably it will fix also #10359.

It seems that mousedown event attached to HOT's root element is executed twice when we have HOT in HOT element. One event is called for the main instance and the second is for the editor being a Handsontable.

This PR adds an extra conditional, which checks whether a callback should be executed.

How has this been tested?

Tested on cases mentioned in the issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/519
  2. Hovering "handsontable" cell type header handles won't throw an error #10458
  3. Hovering embedded table header cell crashes the app #10359

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
  • My change requires a change to the documentation.

@wszymanski wszymanski self-assigned this Jan 31, 2024
@wszymanski wszymanski marked this pull request as ready for review January 31, 2024 18:13
Copy link

github-actions bot commented Feb 9, 2024

Launch the local version of documentation by running:

npm run docs:review ccf5398e9df83c6337e3b261597347f60f412099

@jansiegel jansiegel merged commit 25abcf1 into develop Feb 9, 2024
21 checks passed
@jansiegel jansiegel deleted the feature/issue-dev-519-v2 branch February 9, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants