Add missing react next demo packages #10495
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Please do not merge this pull request. I am creating it only to better understand packages spread across the repo. As i am preparing to create PR that's going to overwrite much of this demo
What i did:
Steps 4 and 5 failed with
Because of failed build i could not run tests. When i added
eslint-config-react-app
i could start, build, and run tests.As i understand this,
eslint-config-react-app
package is currently missing from this demo. However, given how it's present in every demo package-lock.json, i understand i may be missing a stepI understand that "react-scripts" (https://github.com/handsontable/handsontable/blob/develop/examples/next/docs/react/demo/package.json#L25) have
eslint-config-react-app
dependency. For some reason, latter does not install.Thanks
How has this been tested?
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: