Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependencies react/vue for next, ^13.0.0 versions #10523

Closed

Conversation

evanSe
Copy link
Member

@evanSe evanSe commented Sep 29, 2023

Context

It is not possible to run some of the demos in stackblitz, namely for react/vue in the next & ^13.0.0 versions.

In the future we can fix other versions, just very tedious

How has this been tested?

going to the following URLs and seeing that they load and are functional

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/next/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/next/docs/vue/demo

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.1.0/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.1.0/docs/vue/demo

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.0.0/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.0.0/docs/vue/demo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@evanSe evanSe changed the title add missing dependencies react/vlue for next, ^13.0.0 versions add missing dependencies react/vue for next, ^13.0.0 versions Sep 30, 2023
@evanSe evanSe mentioned this pull request Oct 2, 2023
12 tasks
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@evanSe
Copy link
Member Author

evanSe commented Oct 3, 2023

Closing as this is a cross fork pull request, reopened #10525

@evanSe evanSe closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants