Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependencies react/vue for next, ^13.0.0 versions #10525

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

evanSe
Copy link
Member

@evanSe evanSe commented Oct 3, 2023

Context

It is not possible to run some of the demos in stackblitz, namely for react/vue in the next & ^13.0.0 versions.

In the future we can fix other versions, just very tedious

How has this been tested?

going to the following URLs and seeing that they load and are functional

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/next/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/next/docs/vue/demo

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.1.0/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.1.0/docs/vue/demo

https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.0.0/docs/react/demo
https://stackblitz.com/github/evanSe/handsontable/tree/develop/examples/13.0.0/docs/vue/demo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@budnix
Copy link
Member

budnix commented Oct 3, 2023

@evanSe The examples for version 13.0.0 fail because there is a missing NODE_OPTIONS=--openssl-legacy-provider option (required by webpack on >Node 16). I'd propose reverting the changes for 13.0.0 and leaving them for 13.1.0 and next or adding the openssl-legacy-provider flag to all demos.

@evanSe
Copy link
Member Author

evanSe commented Oct 5, 2023

@evanSe The examples for version 13.0.0 fail because there is a missing NODE_OPTIONS=--openssl-legacy-provider option (required by webpack on >Node 16). I'd propose reverting the changes for 13.0.0 and leaving them for 13.1.0 and next or adding the openssl-legacy-provider flag to all demos.

Went with the legacy provider route as we already have some using it

@evanSe evanSe merged commit 010265d into develop Oct 5, 2023
61 checks passed
@evanSe evanSe deleted the evanSe/fix-latest-stackblitz branch October 5, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants