-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS code examples #10990
TS code examples #10990
Conversation
Launch the local version of documentation by running: npm run docs:review fdf2eb9e6cbad6a13ca28529a634f925a6746a07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general everything looks good, a few improvements I would create.
- generate multiple examples files at once (currently it takes along time)
- do have generation as part of start script if its so slow.
If speeding up the script takes more than an hour I wouldn't bother with it
Also its worth rebasing this branch, it has 165 commits currently. |
7064854
to
5095c10
Compare
Rebased. @evanSe please re-review. |
@sequba There is a problem when running |
Currently, |
…menu/javascript/example3.ts
…o-csv/javascript/example1.ts
…ta/javascript/example4.ts
* make sure we evaluate the cache restore properly * build and serve for visual tests * increase timeout
2031e7d
to
9830081
Compare
Context
There are 192 js files in the
docs/content/guides
dir:How has this been tested?
This has been tested locally plus using visual tests for regression checking
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist:
[skip changelog]