Fix/docs visual cache logic #11014
Merged
Fix/docs visual cache logic #11014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequba
approved these changes
Jun 10, 2024
|
Launch the local version of documentation by running: npm run docs:review da249708d3e024511d043cb1ef4940e30e62ad9f |
magierg
merged commit 2031e7d
into
feature/dev-issue-1867-without-1905
20 of 21 checks passed
evanSe
pushed a commit
that referenced
this pull request
Jun 11, 2024
* make sure we evaluate the cache restore properly * build and serve for visual tests * increase timeout
sequba
added a commit
that referenced
this pull request
Jun 11, 2024
* SPIKE - add script that compiles an example TS file to JS * Adjust the start script to make it work in Windows env * Extend the base eslintrc in the eslintrc for example files * Add a bash script that generates the JS files for all the TS example files * Add generate-js-examples step to the npm scripts * Make the generate-js-examples script apply only for the vanilla js examples * Renamed all js examples to *.ts without changing the content * Add typings for data array in the examples (array of arrays) * Add typings for HOT instance in all TS examples * Add typings for data array in the examples (array of objects) * Improve reporting in the generate-js-examples script * Add typings for the HOT instance in the examples * Improve typings in docs/content/guides/accessories-and-menus/context-menu/javascript/example3.ts * Improve typings in docs/content/guides/accessories-and-menus/export-to-csv/javascript/example1.ts * Add typing for .getPlugin statements * Change typing for HOT instance from Handsontable to Core * Add typings for custom renderers in the ts examples * Add missing import statements * Improve typings for arrays * replace Core type * add lint rules * update lint * update ts examples * Newline at the end of file gitignore * Remove unused vars in docs/content/guides/getting-started * Remove unused 'const hot' variables * Fix type error for html containers for the HOT instance * Fix typings in docs/content/guides/rows/row-prepopulating/javascript/example1.ts * Make all HOT instances variables names consistently 'hot' * Improve typings in docs/content/guides/getting-started/binding-to-data * add ts fixes and cleanup * Improve typings for cells() function in HOT configuration * Fix docs/content/guides/columns/column-filter/javascript/exampleFilterDifferentTypes.ts * Fix typings for docs/content/guides/getting-started/demo/javascript/example.ts * Fix type-null-checking in HTML elements * fix example * Fix typing for HTMLInputElement vars * Fix docs/content/guides/optimization/batch-operations/javascript/example1.ts * Fix typings in dir docs/content/guides/cell-functions * Fix typings in dir docs/content/guides/columns * Fix typings in dir docs/content/guides/cell-features * Fix typings in dir docs/content/guides/cell-types * Fix typings in dir docs/content/guides/formulas * Fix typings in dir docs/content/guides/navigation * Fix typings in dir docs/content/guides/accessories-and-menus * Improve typings for docs/content/guides/getting-started/binding-to-data/javascript/example4.ts * Revert unnecessary changes * Revert unnecessary changes * Make generate-js-examples script re-generate files even when exist * Make sure generate-js-examples.sh is run in bash shell * Remove generate-js-examples script from the docs:start pipeline * Make generate-js-examples script run jobs in parallel to speed things up * Improve the dev experience with the generate-js-examples script * Fix merge errors * Fix merge errors * Make generat-js-examples script work in zsh env (MacOS) * Fix/docs visual cache logic (#11014) * make sure we evaluate the cache restore properly * build and serve for visual tests * increase timeout * fix lock * resolve docs lock * update locks --------- Co-authored-by: adrianspdev <adrian.dusinkiewicz@soppo.team> Co-authored-by: Maciej Giergiczny <maciej.giergiczny@handsontable.com> Co-authored-by: Evan Seaward <seaward.evan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
Context
This PR is fixing caching logic in GH workflow plus change the way the build is served for visual tests
How has this been tested?
tested locally and using GH workflow
Types of changes
Related issue(s):
Affected project(s):
handsontable@handsontable/angular@handsontable/react@handsontable/vue@handsontable/vue3Checklist: