Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All store.ErrNotLeader should be replaced with raft.ErrNotLeader #2

Closed
chengshiwen opened this issue Jan 27, 2022 · 1 comment
Closed

Comments

@chengshiwen
Copy link

store.Join maybe return raft.ErrNotLeader, so store.ErrNotLeader shouldn't be used, and all store.ErrNotLeader should be replaced with raft.ErrNotLeader

raftdb/http/service.go

Lines 133 to 136 in d69b747

if err := s.store.Join(nodeID, httpAddr, raftAddr); err != nil {
if err == store.ErrNotLeader {
leader := s.store.LeaderAPIAddr()
if leader == "" {

@hanj4096
Copy link
Owner

hanj4096 commented Feb 4, 2022

fiexed

@hanj4096 hanj4096 closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants