Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistency should be more eager #61

Closed
hannesm opened this issue Jul 1, 2015 · 2 comments
Closed

persistency should be more eager #61

hannesm opened this issue Jul 1, 2015 · 2 comments

Comments

@hannesm
Copy link
Owner

hannesm commented Jul 1, 2015

atm, only on /quit anything is written (apart from configuration) -- but if computer crashes or jackline gets killed, the information is lost, specifically:

  • verified otr fingerprints
  • modified otr policies
  • potential logs

this should be either written when a modification took place, or every X minutes/seconds. prefered the former (with some sort of lock, similar to the notification.state, to avoid races)
@hannesm
Copy link
Owner Author

hannesm commented Jul 11, 2015

this is now in #62, I test it locally a bit but am a bit hesitant to merge before rethinking/rereading the PR... @sg2342 @cfcs if you've some spare time, would be great if you read through and/or test (likely I haven't considered all the possible corner cases)

@hannesm
Copy link
Owner Author

hannesm commented Jul 20, 2015

that's now fixed and merged

@hannesm hannesm closed this as completed Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannesm