Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming is way too slow for large models #25

Closed
hannobraun opened this issue Dec 20, 2021 · 2 comments · Fixed by #764
Closed

Zooming is way too slow for large models #25

hannobraun opened this issue Dec 20, 2021 · 2 comments · Fixed by #764
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

Zooming is way too slow with large models. With the enclosure model, zooming basically does nothing.

Right now, there's a given standard zoom speed that is limited by how close the model is, to make viewing details up-close practical. I think this should probably be changed to make zoom speed dependent on distance to the model. Basically, however far away you are, zoom speed should work comfortably, never being too fast or too slow.

If anyone wants to look into this, basically all the relevant code is in zoom.rs. Specifically the speed limiting code is interesting, and would have to be replaced when fixing this.

@hannobraun hannobraun added type: bug Something isn't working good first issue Good for newcomers topic: input labels Dec 20, 2021
@hannobraun hannobraun changed the title Zooming is way too slow Zooming is way too slow for large models Dec 23, 2021
@hannobraun
Copy link
Owner Author

As part of addressing this, it would make sense to add a large model the the repository. Doesn't need to be anything special (could be as simple as a cube, or something like that). It would just serve as a test case for input on large models.

@eLVas
Copy link
Contributor

eLVas commented May 30, 2022

To be more precise the issue starts to be noticeable with models where at least one side of the bounding box is above 1000.0. And becomes really obvious at around 10000.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants