-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Operator to support changelog extraction #394
Comments
Honestly, I don't think that's worth the effort. Since releases are pretty prominent in the GitHub UI and shown to my followers in their timeline, I view releases rather as a user-facing announcement, and less of a "technical details for nerds" thing, which is what the changelog is. Therefore, I want the release to show the full release announcement, with high-level description, screenshots, etc. While the changelog would certainly be a better placeholder than the last commit message, I don't think it's worth to write code to extract it, if I'm going to replace the contents anyway. I have two alternative suggestions:
I think I'm doing a decent job with the HTML I generate on the website, so the second point should be relatively straight-forward, actually. The procedure would probably be something like this:
The only question is, how well will that HTML play with the Markdown input that GitHub accepts. In principle, it should be valid Markdown, but I don't know if GitHub is filtering any tags. |
According to the GitHub Markdown spec, that could work out just fine:
Source: https://github.github.com/gfm/#raw-html Let's go with the release announcement from the website then. |
In an effort to keep the number of open issues down to a reasonable number, I'm folding this issue into #104. I'll close this one and add a reference to it over there. |
With #391, we put the new release-operator in place. the workflow will also create the respective GitHub Release resource with all binaries and their checksums attached. However, the body of the release resource won't contain any changelog. In fact, it will default to the last commit message as of now.
Hence I would propose to extend the release-operator to extract the relevant part of the changelog file. It can then be put into the Release resource upon its creation.
Since the headlines in the changelog always start with the SemVer identifier, it should be enough to parse the document with three values given: path to the changelog, previous tag, current tag:
The text was updated successfully, but these errors were encountered: