Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate API for adding/removing watches #177

Closed
hannobraun opened this issue May 28, 2021 · 0 comments · Fixed by #197
Closed

Add separate API for adding/removing watches #177

hannobraun opened this issue May 28, 2021 · 0 comments · Fixed by #197

Comments

@hannobraun
Copy link
Owner

Add a separate Watches struct that provides add and remove methods to replace Inotify::add_watch/Inotify::rm_watch. It should be possible to get an instance of this struct from Inotify and EventStream (for example via watches methods on each).

I think there should be no harm in making Watches completely independent (i.e. no need to borrow Inotify or EventStream) and make it Clone.

See #112 (comment) and #112 (comment) for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant