Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift implementation and tests are inconsistent with documentation #30

Open
jbfaden opened this issue Jul 10, 2024 · 0 comments
Open

shift implementation and tests are inconsistent with documentation #30

jbfaden opened this issue Jul 10, 2024 · 0 comments

Comments

@jbfaden
Copy link
Collaborator

jbfaden commented Jul 10, 2024

The implementation and tests of shift at https://github.com/hapi-server/uri-templates/blob/59b40015d367328282e71c102bde7e6c941fb886/formatting.json#L275 are inconsistent with the documentation. If the last day of a five-day interval in "$Y-$m-$d/$(Y;end)-$m-$d" is included, then should shift be 1 or -1? The documentation indicates it should be -1, while the tests and implementations have 1 for the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant