Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with not exist required param 'v' last versitons today 5.… #349

Merged
merged 5 commits into from Apr 2, 2018

Conversation

@slaawwa
Copy link
Contributor

slaawwa commented Mar 3, 2018

@slaawwa

This comment has been minimized.

Copy link
Contributor Author

slaawwa commented Mar 3, 2018

This pull request for issue
#348

@zetokz

This comment has been minimized.

Copy link

zetokz commented Mar 3, 2018

I guess you can cover it with the test.

slaawwa added 2 commits Mar 3, 2018
@zetokz
zetokz approved these changes Mar 3, 2018
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 8, 2018

Please fix coverage by adding a test.

@hueniverse hueniverse self-assigned this Mar 8, 2018
@hueniverse hueniverse added the bug label Mar 8, 2018
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 9, 2018

@slaawwa if you need help with the tests let us know!

@slaawwa

This comment has been minimized.

Copy link
Contributor Author

slaawwa commented Mar 18, 2018

@AdriVanHoudt, hi. Thanks)
I try. Find example and I think add test.
Please check if you have time)

Copy link
Contributor

AdriVanHoudt left a comment

LGTM

@hueniverse hueniverse added this to the 9.2.0 milestone Apr 2, 2018
@hueniverse hueniverse merged commit ba1ed3c into hapijs:master Apr 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.