Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with not exist required param 'v' last versitons today 5.… #349

Merged
merged 5 commits into from
Apr 2, 2018

Conversation

slaawwa
Copy link
Contributor

@slaawwa slaawwa commented Mar 3, 2018

@slaawwa
Copy link
Contributor Author

slaawwa commented Mar 3, 2018

This pull request for issue
#348

@yevhenii-rechun
Copy link

I guess you can cover it with the test.

@hueniverse
Copy link
Contributor

Please fix coverage by adding a test.

@hueniverse hueniverse self-assigned this Mar 8, 2018
@hueniverse hueniverse added the bug Bug or defect label Mar 8, 2018
@AdriVanHoudt
Copy link
Contributor

@slaawwa if you need help with the tests let us know!

@slaawwa
Copy link
Contributor Author

slaawwa commented Mar 18, 2018

@AdriVanHoudt, hi. Thanks)
I try. Find example and I think add test.
Please check if you have time)

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hueniverse hueniverse added this to the 9.2.0 milestone Apr 2, 2018
@hueniverse hueniverse merged commit ba1ed3c into hapijs:master Apr 2, 2018
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants