Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.truncateMessages = false causes issues with deep object comparisons #30

Closed
marshall007 opened this issue Jun 15, 2015 · 2 comments · Fixed by #31
Closed

settings.truncateMessages = false causes issues with deep object comparisons #30

marshall007 opened this issue Jun 15, 2015 · 2 comments · Fixed by #31
Assignees
@cjihrig
Labels
bug Bug or defect
Milestone
1.4.1

Comments

@marshall007
Copy link

It looks like the line on lib/index.js#L344 assumes that the message portion of error.stack will only be one line (i.e. the .slice(1)). However, when Code.settings.truncateMessages = false the object is pretty-printed and the stacktrace looks like this:

Error: Expected { foo: 'bar'
  hello: 'world' } to equal specified value
  at ...
@cjihrig cjihrig added the bug Bug or defect label Jun 16, 2015
@cjihrig cjihrig added this to the 1.4.1 milestone Jun 16, 2015
@cjihrig cjihrig self-assigned this Jun 16, 2015
@cjihrig cjihrig mentioned this issue Jun 16, 2015
Merged
@arb arb closed this as completed in #31 Jun 16, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Jun 16, 2015

Published in v1.4.1

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cjihrig cjihrig

Labels
bug Bug or defect
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

Handle multi-line errors
2 participants
@marshall007 @cjihrig