Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`settings.truncateMessages = false` causes issues with deep object comparisons #30

Closed
marshall007 opened this issue Jun 15, 2015 · 1 comment · Fixed by #31
Assignees
Labels
bug
Milestone

Comments

@marshall007
Copy link

@marshall007 marshall007 commented Jun 15, 2015

It looks like the line on lib/index.js#L344 assumes that the message portion of error.stack will only be one line (i.e. the .slice(1)). However, when Code.settings.truncateMessages = false the object is pretty-printed and the stacktrace looks like this:

Error: Expected { foo: 'bar'
  hello: 'world' } to equal specified value
  at ...
@cjihrig cjihrig added the bug label Jun 16, 2015
@cjihrig cjihrig added this to the 1.4.1 milestone Jun 16, 2015
@cjihrig cjihrig self-assigned this Jun 16, 2015
@arb arb closed this in #31 Jun 16, 2015
@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Jun 16, 2015

Published in v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.