Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session is not being set in FX 39 and Chrome 43 #60

Closed
cadecairos opened this issue Apr 7, 2015 · 7 comments
Closed

Session is not being set in FX 39 and Chrome 43 #60

cadecairos opened this issue Apr 7, 2015 · 7 comments
Assignees
Labels
non issue Issue is not a problem or requires changes

Comments

@cadecairos
Copy link

These dev browsers (FX 39 and Chrome 43) appear to be unable (or unwilling?) to set a session cookie generated by hapi-auth-cookie.

Here's my reduced test case: https://gist.github.com/cadecairos/5bcfa6aeba06c2c69952

@jaw187
Copy link
Contributor

jaw187 commented Apr 7, 2015

I can't think of anything special which hapi-auth-cookie is doing to set the cookie which would introduce this problem. Can you test cookies from other applications/sites using the dev browsers?

@jaw187 jaw187 self-assigned this Apr 7, 2015
@cadecairos
Copy link
Author

I use Firefox developer edition as my daily driver, and haven't seen anything like this. I also checked that express session cookies properly get set on localhost in both dev versions.

@jaw187
Copy link
Contributor

jaw187 commented Apr 7, 2015

Have you tested setting a cookie through a traditional request instead of using an Ajax request? In the end, this issue will most likely be moved to https://github.com/hapijs/statehood

@cadecairos
Copy link
Author

I'll give that a try next time I'm at my computer.

@cadecairos
Copy link
Author

Turns out this was a bug with the polyfill of fetch setting withCredentials to true by default, and me not providing the credentials mode option to fetch. It broke in Firefox and Chrome Dev versions because they have the fetch API implemented.

@jaw187
Copy link
Contributor

jaw187 commented Apr 15, 2015

👍

@hueniverse hueniverse added the non issue Issue is not a problem or requires changes label Apr 20, 2015
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
non issue Issue is not a problem or requires changes
Projects
None yet
Development

No branches or pull requests

3 participants