Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for partial response before compressing response #3133

Closed
kanongil opened this issue May 2, 2016 · 2 comments
Closed

Check for partial response before compressing response #3133

kanongil opened this issue May 2, 2016 · 2 comments
Labels
feature New functionality or improvement

Comments

@kanongil
Copy link
Contributor

kanongil commented May 2, 2016

The issue in hapijs/inert#60 / #3132 could have been avoided if Hapi did a check for response code 206 before applying compression to the response.

As far as I can tell, it is never appropriate for Hapi to compress a response with status code 206.
@nrotta nrotta mentioned this issue Jun 9, 2016
Closed
@nlf nlf added the request label Jun 10, 2016
@kanongil
Copy link
Contributor Author

kanongil commented Jul 6, 2016

FYI, I consider this a bug in hapi, unless someone can tell me when implicitly compressed 206 responses are valid?

@Marsup Marsup added feature New functionality or improvement and removed request labels Sep 20, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature New functionality or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nlf @kanongil @Marsup