How to detect if path does not exist 404

[digitaldesigndj]

I am trying to setup a cache proxy thing, if the file is on disk I want to just serve it up, otherwise I'll proxy the request, pipe the response to the client, and write the file to disk. I have the code for the proxy working fine, I would just like to hook into reply.file() if it is going to return a 404 error. Is this possible, or beyond the scope of this module?

[hueniverse]

You can do this now with onPreResponse extension. Not as clean as a native extension to this module where you can specify an error handler fallback. But also not sure if it's worth the complexity here. I'll let @kanongil decide.

[digitaldesigndj]

Thanks for the help, that's exactly what I needed. There's a little bit of new route detection that I had to do, but it may actually be cleaner this way.

That could just be because my app is small right now however.

[kanongil]

I agree with the approach @hueniverse offered, though I would probably use a plain directory handler, and handle the proxy behavior in the onPreResponse hook.

To detect when to apply this behavior, as the hook is called for all routes, you can use the app route config, which can be accessed from the extension point handler via request.route.settings.app.

I will leave this request open for now in case others want to chime in but I don't really think it is worth the effort to include this functionality in inert.

[digitaldesigndj]

I did look at onPreResponse I can't still say for sure why I didn't take that route, but I can say that I looked at it for a bit. I can say also that this proxy stuff is super helpful when injecting node.js into a stale corporate environment. Even if the application was small, it came together quick.

This app really tears the face off of a bad site, and it's gonna take a crowbar to get this sucker off.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.