Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose prefs in external() #2455

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Expose prefs in external() #2455

merged 1 commit into from
Oct 24, 2020

Conversation

matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Aug 26, 2020 •
edited
Loading

Fixes part of #2402

@matthieusieben
Copy link
Contributor Author

I'm aware this is not exactly what's expected but it fixes the requested features (from #2367 & #2376), while still allowing to add the full helpers in the future.

@hueniverse hueniverse merged commit f5f6e62 into hapijs:master Oct 24, 2020
@hueniverse hueniverse self-assigned this Oct 24, 2020
@hueniverse hueniverse added the feature New functionality or improvement label Oct 24, 2020
@hueniverse hueniverse added this to the 17.2.2 milestone Oct 24, 2020
@matthieusieben matthieusieben deleted the fix-2402-external-helpers branch October 27, 2020 11:43
@api-haus api-haus mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hueniverse hueniverse

Labels
feature New functionality or improvement
Projects
None yet
Milestone
17.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matthieusieben @hueniverse