Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report "Type T has no properties in common with type U" as a type error #1046

Closed
devinivy opened this issue May 1, 2022 · 0 comments
Closed
Assignees
Labels
bug Bug or defect
Milestone

Comments

@devinivy
Copy link
Member

devinivy commented May 1, 2022

In updating hoek's version of typescript, one of the type tests failed because it wasn't flagged as a type error: https://github.com/hapijs/hoek/blob/71250a0d187bafe3b31cc3a86a3ce306e0d99734/test/index.ts#L69

The error in this case is "Type 'true' has no properties in common with type 'Options'", error code 2559. We need to add 2559 to the list to pick-up this potential type error.

@devinivy devinivy added the bug Bug or defect label May 1, 2022
@devinivy devinivy added this to the 2.47.1 milestone May 1, 2022
@devinivy devinivy self-assigned this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect
Projects
None yet
Development

No branches or pull requests

1 participant