Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting information and test failures to html #448

Merged
merged 1 commit into from Sep 21, 2015
Merged

Conversation

@Marsup
Copy link
Member

Marsup commented Sep 21, 2015

First, sorry for the massive refactor ;)

This patch :

  1. adds tooltips on most elements of the page (#439)
  2. adds margin marks in the coverage section about linting errors
  3. repeats those linting errors at the bottom of the report in case coverage is not enabled
  4. adds a list of test script errors at the bottom of test errors

[1]
1
2
[2]
3
[3]
4
[4]
5

@geek geek added the feature label Sep 21, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Sep 21, 2015

@Marsup you are on a roll... thank you!

@geek geek self-assigned this Sep 21, 2015
@geek geek added this to the 5.17.1 milestone Sep 21, 2015
geek added a commit that referenced this pull request Sep 21, 2015
Add linting information and test failures to html
@geek geek merged commit 4bcdb49 into hapijs:master Sep 21, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Sep 21, 2015

Consequences of giving a nodejs training last week and seeing trainees lost as to why the tests failed while the report shown nothing ;)

@skeggse

This comment has been minimized.

Copy link
Contributor

skeggse commented Sep 22, 2015

Marvelous, thanks!

@Marsup Marsup deleted the Marsup:html-lint branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.