Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec style formatting #56

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ suite('math', function () {
**lab** supports the following command line options:
- `-r` - the reporter used to generate the test results. Defaults to `console`. Options are:
- `console` - simple text output to console
- `spec` - specification output to console
- `coverage` - JSON code coverage report
- `html` - HTML code coverage report
- `threshold` - Code coverage percentage check
Expand Down
100 changes: 65 additions & 35 deletions lib/execute.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports.execute = function (skipTraverse) {

.alias('r', 'reporter')
.default('r', 'console')
.describe('r', 'reporter module [console, json, html, coverage, threshold]')
.describe('r', 'reporter module [console, spec, json, html, coverage, threshold]')

.alias('s', 'silence')
.default('s', false)
Expand Down Expand Up @@ -153,8 +153,11 @@ exports.execute = function (skipTraverse) {

// Subscribe reporter to events

// test - (test, failed, err) test results
// end - (ms) execution complete
// start - () execution start
// startExperiment - (experiment) experiment start
// test - (test) test results
// endExperiment - (experiment) experiment end
// end - (ms) execution complete

var emitter = new Events.EventEmitter();

Expand All @@ -169,38 +172,12 @@ exports.execute = function (skipTraverse) {

Reporter[argv.r](emitter, options);

var failures = 0;

// Execute experiments

var startTime = Date.now();
Async.forEachSeries(Lab.experiments, function (experiment, nextExperiment) {

Async.series([
function (next) {

internals.executeDeps(experiment.befores, next);
},
function (next) {

internals.executeTests(experiment, emitter, options.ids, next);
},
function (next) {

internals.executeDeps(experiment.afters, next);
}
],
function (err, results) {

failures += results.failures;
if (err) {
failures++;
}
emitter.emit('start');

nextExperiment();
});
},
function (err) {
internals.executeExperiment(Lab.root, emitter, options.ids, function (err, failures) {

var leaks = null;
if (argv.G) {
Expand Down Expand Up @@ -232,8 +209,61 @@ internals.executeDeps = function (deps, callback) {
});
};

internals.executeExperiment = function (experiment, emitter, ids, callback) {

var failures = 0;

if (experiment.parent) {
emitter.emit('startExperiment', experiment);
}

Async.series([
function (next) {

internals.executeDeps(experiment.befores, next);
},
function (next) {

internals.executeTests(experiment.tests, emitter, ids, next);
},
function (next) {

internals.executeExperiments(experiment.experiments, emitter, ids, next);
},
function (next) {

internals.executeDeps(experiment.afters, next);
}
], function (err, results) {

failures += results[1] + results[2];
if (err) {
failures++;
}

if (experiment.parent) {
emitter.emit('endExperiment', experiment);
}
callback(err, failures);
});
}

internals.executeExperiments = function (experiments, emitter, ids, callback) {

var failures = 0;

Async.forEachSeries(experiments || [], function (experiment, nextExperiment) {
internals.executeExperiment(experiment, emitter, ids, function(err, experimentFailures) {
failures += experimentFailures;
nextExperiment();
});
},
function (err) {
callback(err, failures);
});
};

internals.executeTests = function (experiment, emitter, ids, callback) {
internals.executeTests = function (tests, emitter, ids, callback) {

var failures = 0;

Expand All @@ -257,7 +287,7 @@ internals.executeTests = function (experiment, emitter, ids, callback) {
});
}

Async.forEachSeries(experiment.tests || [], function (test, nextTest) {
Async.forEachSeries(tests || [], function (test, nextTest) {

if (ids.length &&
ids.indexOf(test.id) === -1) {
Expand All @@ -268,15 +298,15 @@ internals.executeTests = function (experiment, emitter, ids, callback) {
Async.series([
function (next) {

internals.executeDeps(experiment.beforeEaches, next);
internals.executeDeps(test.parent.beforeEaches, next); // query: should do ancestors not just parent
},
function (next) {

runTest(test, next);
},
function (next) {

internals.executeDeps(experiment.afterEaches, next);
internals.executeDeps(test.parent.afterEaches, next); // query: should do ancestors not just parent
}
], function (err, results) {

Expand Down
28 changes: 20 additions & 8 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,38 @@ var internals = {};
});
*/

exports.root = {}; // root wraps any top level elements
exports.experiments = [exports.root]; // preserve for backwards compatibility - deprecated
exports.index = {};

internals.id = 0;
internals.current = {};
internals.current = exports.root;
internals.titles = [];

exports.experiments = [internals.current];
exports.index = {};

Chai.config.includeStack = true; // Show the stack where where the issue occurs


exports.experiment = exports.describe = function (title, fn) {

var prev = internals.current;
var experiment = {
parent: internals.current,
path: internals.titles.join('/'),
title: internals.titles.join(' ') + ' ' + title,
relativeTitle: title
};

internals.current = {};
exports.experiments.push(internals.current);
internals.current.experiments = internals.current.experiments || [];
internals.current.experiments.push(experiment);
exports.experiments.push(experiment);

var prev = internals.current;
internals.current = experiment;

internals.titles.push(title);
fn();
internals.titles.pop();

internals.current = prev;
};

Expand All @@ -55,7 +66,7 @@ exports.before = function (fn) {
title: 'Before ' + internals.titles.join(' '),
fn: fn
};

internals.current.befores = internals.current.befores || [];
internals.current.befores.push(before);
};
Expand Down Expand Up @@ -100,6 +111,7 @@ exports.afterEach = function (fn) {
exports.test = exports.it = function (title, fn) {

var test = {
parent: internals.current,
id: ++internals.id,
path: internals.titles.join('/'),
title: internals.titles.join(' ') + ' ' + title,
Expand All @@ -109,7 +121,7 @@ exports.test = exports.it = function (title, fn) {

internals.current.tests = internals.current.tests || [];
internals.current.tests.push(test);

exports.index[test.id] = test;
};

Expand Down
Loading