Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Wait for stdout to stop writing to exit" #831

Merged
merged 1 commit into from May 7, 2018

Conversation

@geek
Copy link
Member

geek commented May 7, 2018

Reverts #829

This is causing the following error to occur on node 10:

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: read ENOTCONN
    at WriteStream.Socket._read (net.js:530:20)
    at WriteStream.Readable.read (_stream_readable.js:458:10)
    at resume_ (_stream_readable.js:897:12)
    at process._tickCallback (internal/process/next_tick.js:174:19)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:174:19)
@geek geek added the bug label May 7, 2018
@geek geek added this to the 15.4.4 milestone May 7, 2018
@geek geek requested review from Marsup and lloydbenson May 7, 2018
@geek geek self-assigned this May 7, 2018
@geek geek merged commit b5bbad5 into master May 7, 2018
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the revert-829-wait-for-stdout-end branch Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.