Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition exists in client reconnect logic #18

Closed
kpdecker opened this issue Sep 5, 2015 · 1 comment
Closed

Race condition exists in client reconnect logic #18

kpdecker opened this issue Sep 5, 2015 · 1 comment
Assignees
@hueniverse
Labels
bug Bug or defect
Milestone
0.3.0

Comments

@kpdecker
Copy link
Contributor

kpdecker commented Sep 5, 2015

If the connection is disconnected and then the client actively closes during the reconnect timeout, a throw will occur when attempting to read _reconnection.auth.

self._connect(self._reconnection.auth, function (err) {

https://github.com/hapijs/nes/blob/custom-messages/lib/client.js#L170
@hueniverse hueniverse added the bug Bug or defect label Sep 6, 2015
@hueniverse hueniverse added this to the 0.3.0 milestone Sep 6, 2015
@hueniverse hueniverse self-assigned this Sep 6, 2015
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
bug Bug or defect
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@hueniverse @kpdecker