Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition exists in client reconnect logic #18

Closed
kpdecker opened this issue Sep 5, 2015 · 0 comments
Closed

Race condition exists in client reconnect logic #18

kpdecker opened this issue Sep 5, 2015 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Sep 5, 2015

If the connection is disconnected and then the client actively closes during the reconnect timeout, a throw will occur when attempting to read _reconnection.auth.

self._connect(self._reconnection.auth, function (err) {

https://github.com/hapijs/nes/blob/custom-messages/lib/client.js#L170

@hueniverse hueniverse added the bug label Sep 6, 2015
@hueniverse hueniverse added this to the 0.3.0 milestone Sep 6, 2015
@hueniverse hueniverse self-assigned this Sep 6, 2015
@hueniverse hueniverse closed this in 16503c4 Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.