Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 Release notes #96

Closed
geek opened this issue Jul 1, 2015 · 1 comment
Closed

6.0.0 Release notes #96

geek opened this issue Jul 1, 2015 · 1 comment
Assignees
Labels
breaking changes Change that can breaking existing code release notes Major release documentation
Milestone

Comments

@geek
Copy link
Member

geek commented Jul 1, 2015

Overview

All of the Wreck shortcuts for get, post, put, or delete now work as documented in regards to the value they pass for payload to the callback. Previously, buffer values for payload were converted to strings.

Upgrade Steps

Update any callback functions for get, post, put, or delete to convert the payload value to a string from a buffer if the value was being treated as a string previously.

For example:

Wreck.get('http://hapijs.com', function (err, res, payload) {

    // handle err if exists

    payload = Buffer.isBuffer(payload) ? payload.toString() : payload;
});
@geek geek added breaking changes Change that can breaking existing code release notes Major release documentation labels Jul 1, 2015
@geek geek self-assigned this Jul 1, 2015
@geek geek added this to the 6.0.0 milestone Jul 1, 2015
@geek geek closed this as completed Jul 1, 2015
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code release notes Major release documentation
Projects
None yet
Development

No branches or pull requests

1 participant