Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift syntax styling not complete #14

Closed
trozware opened this issue Mar 13, 2016 · 6 comments
Closed

Swift syntax styling not complete #14

trozware opened this issue Mar 13, 2016 · 6 comments

Comments

@trozware
Copy link

Other languages that I have checked look OK, but Swift does not render the same as it does on the desktop app.

@ylian
Copy link
Member

ylian commented Mar 17, 2016

It's because I have updated the Swift syntax highlighter. Is it actually worse than the previous one? Then I would need to revert it back.

@trozware
Copy link
Author

The 2 attached files show exactly the same cells formatted in Quiver for Mac and Quiver for iPad both using the Solarized Light theme.
There are a lot fewer colored tokens in the iPad version. Checking in Xcode, I see that it is different to both but that is the goal I think you should be aiming for.

Mac:
mac

iPad:
ipad

@ylian
Copy link
Member

ylian commented Mar 18, 2016

Thanks. I will revert it back.

@ylian
Copy link
Member

ylian commented Mar 18, 2016

Actually I was able to merge the two. Please try this beta build (3.0.2 Build 85): https://dl.dropboxusercontent.com/u/3445731/Quiver%203.0.2%20Build%2085.zip

@trozware
Copy link
Author

I like this version a lot :-)

Here is the same script shown in the beta.

On Mar 18, 2016, at 3:00 PM, Yaogang Lian notifications@github.com wrote:

Actually I was able to merge the two. Please try this beta build (3.0.2 Build 85): https://dl.dropboxusercontent.com/u/3445731/Quiver%203.0.2%20Build%2085.zip


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@ylian
Copy link
Member

ylian commented May 13, 2016

Fixed in Build 7.

@ylian ylian closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants